commit | 5f270c515ba81c8eb26c0bf3ba4a1f89b95d6ed3 | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Fri Mar 17 03:33:15 2023 +0000 |
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Fri Mar 17 03:49:41 2023 +0000 |
tree | 8943e6937dd958a0ec2994e4de75bb1b4b02fbc4 | |
parent | 288fd7e8ae31f64747f17ee439fc4dc26c76e5e9 [diff] |
[elements-sk] Rewrite all imports using a bespoke Go program. This CL is the result of: - Running the rewrite_imports.go program at https://skia-review.googlesource.com/c/buildbot/+/654405/2/rewrite_imports/rewrite_imports.go - Running "make gazelle". Success criteria: This CL should not cause any Gold diffs. I removed the rewrite_imports.go program in a subsequent patchset as it is a one-off utility. This program does the following things: - Rewrites all common-sk imports to use modules in the buildbot repo. - Same for elements-sk, but with the following special cases. - It moves any elements-sk style imports from TypeScript sources into the corresponding Sass sources. - Style import paths are rewritten from e.g. elements-sk/styles/button/button.scss to elements-sk/modules/styles/button. - Icon imports are rewritten from elements-sk/icon/some-icon-sk to elements-sk/modules/icons/some-icon-sk. Bug: skia:14161 Change-Id: I9d319b894df1dff01f8300233104097f680493be Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/654405 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small