commit 8168f312b4064896237cd8564f8e09f66b7bce43
author Sam Lantinga <slouken@libsdl.org> Tue Jun 02 17:08:31 2020 -0700
committer Sam Lantinga <slouken@libsdl.org> Tue Jun 02 17:08:31 2020 -0700
tree 6c6f2a68e2a2954d9c1f9db8f0b365305888d570
parent 1913806106d192625f86122f8ce0a6ff5d37756f

Fixed bug 5168 - Memory leak in RAWINPUT_JoystickOpen

meyraud705

Variable 'hwdata' is not freed in RAWINPUT_JoystickOpen if device->driver->OpenJoystick() fails.

src/joystick/windows/SDL_rawinputjoystick.c

diff --git a/src/joystick/windows/SDL_rawinputjoystick.c b/src/joystick/windows/SDL_rawinputjoystick.c
index 4134e4c..9d752bf 100644
--- a/src/joystick/windows/SDL_rawinputjoystick.c
+++ b/src/joystick/windows/SDL_rawinputjoystick.c
@@ -592,8 +592,8 @@
     }
 
     if (!device->driver->OpenJoystick(&device->hiddevice, joystick)) {
-        /* Only possible error is out of memory */
-        return SDL_OutOfMemory();
+        SDL_free(hwdata);
+        return -1;
     }
 
     hwdata->reserved = (void*)-1; /* crash if some code slips by that tries to use this */