commit 31c6c491c36c30351afda0ff48edfd2694ca3916
author Sam Lantinga <slouken@libsdl.org> Sat Mar 16 18:45:10 2019 -0700
committer Sam Lantinga <slouken@libsdl.org> Sat Mar 16 18:45:10 2019 -0700
tree 8fb657b4c07c0ef4c5add323f68551feeab74993
parent 74e23455ab2abbced7d1ef6c610449129582788f

Fixed bug 4544 - SDL2.m4 SDL2.framework patch made it impossible to fail detection

Stian Skjelstad

check if $sdl_framework is set, before checking if directory exists

Patch that was merged here https://hg.libsdl.org/SDL/rev/9befd0acb9ef made it impossible for the SDL2 detection to fail, since one of the if statements fails to check if a variable is set or not.

if test -d $sdl_framework; then

can evaluate to true in some shells. I guess it falls into undefined behaviour when looking at the POSIX standard.

sdl2.m4

diff --git a/sdl2.m4 b/sdl2.m4
index b915f99..0a73bc7 100644
--- a/sdl2.m4
+++ b/sdl2.m4
@@ -74,7 +74,7 @@
         done
       fi
 
-      if test -d $sdl_framework; then
+      if test x"$sdl_framework" != x && test -d "$sdl_framework"; then
         AC_MSG_RESULT($sdl_framework)
         sdl_framework_dir=`dirname $sdl_framework`
         SDL_CFLAGS="-F$sdl_framework_dir -Wl,-framework,SDL2 -I$sdl_framework/include"