commit f57f12d53abb10a05057654fa805a45595bab43b
author Brian Osman <brianosman@google.com> Mon Jul 19 14:24:11 2021 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Jul 20 00:16:10 2021 +0000
tree eed8b075dee27915e0522a2979d52d739427764e
parent ee8b8e1984d5f7b112532ad46bc0d2d4acbc8c58

Fix symbol escaping in bloaty_treemap

All JS strings are now single-quoted, so double-quotes don't need
escaping. There are some symbols (in fullsymbols mode) that contain
single quotes, though - so escape those instead.

Change-Id: Ibdcca5634413c6a5e292f81503fbbf89f3d52b0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430040
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

tools/bloaty_treemap.py

diff --git a/tools/bloaty_treemap.py b/tools/bloaty_treemap.py
index 28eb469..a721b57 100755
--- a/tools/bloaty_treemap.py
+++ b/tools/bloaty_treemap.py
@@ -89,8 +89,8 @@
                 print("ERROR: Unexpected absolute path:\n" + filepath)
                 sys.exit(1)
 
-        # It's rare, but symbols can contain double-quotes (it's a valid C++ operator)
-        symbol = symbol.replace('"', '\\"')
+        # Symbols involving C++ lambdas can contain single quotes
+        symbol = symbol.replace("'", "\\'")
 
         # Ensure that we've added intermediate nodes for all portions of this file path
         add_path(filepath)