commit f27017072a446dee800d6f4a19df65d639ccc57b
author Brian Osman <brianosman@google.com> Fri May 26 11:09:05 2023 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Fri May 26 16:05:32 2023 +0000
tree cf95c2e5b2b3267ad405048cfafd55759bae0eb1
parent bbd4d3514eec1981e86226b577887c45a4b01d0c

Remove -fno-stack-check from SkOpts code on Mac

This was a workaround for an Apple clang bug that no longer appears to
be relevant. That's good, because the workaround was somewhat dangerous
(potential to trigger seg-faults on uncommitted stack pages).

See comment #15 on the linked bug for a detailed explanation.

Bug: skia:9709
Change-Id: I6489b8ddbcf042e6ebc24065a866373bf64a6064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/703681
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 74072e4..1d8c114 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -192,9 +192,6 @@
     cflags = [ "/arch:AVX" ]
   } else {
     cflags = [ "-mavx" ]
-    if (is_mac && is_debug) {
-      cflags += [ "-fno-stack-check" ]  # Work around skia:9709
-    }
   }
 }
 
@@ -205,9 +202,6 @@
     cflags = [ "/arch:AVX2" ]
   } else {
     cflags = [ "-march=haswell" ]
-    if (is_mac && is_debug) {
-      cflags += [ "-fno-stack-check" ]  # Work around skia:9709
-    }
   }
 }
 
@@ -218,9 +212,6 @@
     cflags = [ "/arch:AVX512" ]
   } else {
     cflags = [ "-march=skylake-avx512" ]
-    if (is_mac && is_debug) {
-      cflags += [ "-fno-stack-check" ]  # Work around skia:9709
-    }
   }
 }