Add makeNotCurrent to TestContext
I find this useful for managing which context is active on threads.
Change-Id: I655955a2351f273751681f080190ca684d29db4e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270642
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
diff --git a/tools/gpu/TestContext.cpp b/tools/gpu/TestContext.cpp
index bf961fb..c1ec90c 100644
--- a/tools/gpu/TestContext.cpp
+++ b/tools/gpu/TestContext.cpp
@@ -35,6 +35,7 @@
return nullptr;
}
+void TestContext::makeNotCurrent() const { this->onPlatformMakeNotCurrent(); }
void TestContext::makeCurrent() const { this->onPlatformMakeCurrent(); }
SkScopeExit TestContext::makeCurrentAndAutoRestore() const {
diff --git a/tools/gpu/TestContext.h b/tools/gpu/TestContext.h
index e48c598..df4cc9e 100644
--- a/tools/gpu/TestContext.h
+++ b/tools/gpu/TestContext.h
@@ -45,6 +45,7 @@
return true;
}
+ void makeNotCurrent() const;
void makeCurrent() const;
/**
@@ -106,6 +107,7 @@
/** This should destroy the 3D context. */
virtual void teardown();
+ virtual void onPlatformMakeNotCurrent() const = 0;
virtual void onPlatformMakeCurrent() const = 0;
/**
* Subclasses should implement such that the returned function will cause the current context
diff --git a/tools/gpu/dawn/DawnTestContext.cpp b/tools/gpu/dawn/DawnTestContext.cpp
index 37c63ce..d834a15 100644
--- a/tools/gpu/dawn/DawnTestContext.cpp
+++ b/tools/gpu/dawn/DawnTestContext.cpp
@@ -233,6 +233,7 @@
fFenceSync.reset(new DawnFenceSync(fDevice));
}
+ void onPlatformMakeNotCurrent() const override {}
void onPlatformMakeCurrent() const override {}
std::function<void()> onPlatformGetAutoContextRestore() const override { return nullptr; }
void onPlatformSwapBuffers() const override {}
diff --git a/tools/gpu/gl/angle/GLTestContext_angle.cpp b/tools/gpu/gl/angle/GLTestContext_angle.cpp
index c7c9149..4dd3638 100644
--- a/tools/gpu/gl/angle/GLTestContext_angle.cpp
+++ b/tools/gpu/gl/angle/GLTestContext_angle.cpp
@@ -101,6 +101,7 @@
private:
void destroyGLContext();
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
void onPlatformSwapBuffers() const override;
@@ -448,6 +449,12 @@
#endif
}
+void ANGLEGLContext::onPlatformMakeNotCurrent() const {
+ if (!eglMakeCurrent(fDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT)) {
+ SkDebugf("Could not reset the context 0x%x.\n", eglGetError());
+ }
+}
+
void ANGLEGLContext::onPlatformMakeCurrent() const {
if (!eglMakeCurrent(fDisplay, fSurface, fSurface, fContext)) {
SkDebugf("Could not set the context 0x%x.\n", eglGetError());
diff --git a/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp b/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp
index cf82e35..1e173cd 100644
--- a/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp
+++ b/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp
@@ -337,6 +337,15 @@
fDisplay = EGL_NO_DISPLAY;
}
+void CommandBufferGLTestContext::onPlatformMakeNotCurrent() const {
+ if (!gfFunctionsLoadedSuccessfully) {
+ return;
+ }
+ if (!TLSCurrentObjects::MakeCurrent(fDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT)) {
+ SkDebugf("Command Buffer: Could not null out current EGL context.\n");
+ }
+}
+
void CommandBufferGLTestContext::onPlatformMakeCurrent() const {
if (!gfFunctionsLoadedSuccessfully) {
return;
diff --git a/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.h b/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.h
index 089c06e..e6b3d70 100644
--- a/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.h
+++ b/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.h
@@ -40,6 +40,7 @@
void destroyGLContext();
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
diff --git a/tools/gpu/gl/egl/CreatePlatformGLTestContext_egl.cpp b/tools/gpu/gl/egl/CreatePlatformGLTestContext_egl.cpp
index f69c80f..af6d110 100644
--- a/tools/gpu/gl/egl/CreatePlatformGLTestContext_egl.cpp
+++ b/tools/gpu/gl/egl/CreatePlatformGLTestContext_egl.cpp
@@ -63,6 +63,7 @@
private:
void destroyGLContext();
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
void onPlatformSwapBuffers() const override;
@@ -301,6 +302,12 @@
return ctx;
}
+void EGLGLTestContext::onPlatformMakeNotCurrent() const {
+ if (!eglMakeCurrent(fDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT )) {
+ SkDebugf("Could not reset the context.\n");
+ }
+}
+
void EGLGLTestContext::onPlatformMakeCurrent() const {
if (!eglMakeCurrent(fDisplay, fSurface, fSurface, fContext)) {
SkDebugf("Could not set the context.\n");
diff --git a/tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp b/tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp
index 5e643e2..c13ea53 100644
--- a/tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp
+++ b/tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp
@@ -61,6 +61,7 @@
static GLXContext CreateBestContext(bool isES, Display* display, GLXFBConfig bestFbc,
GLXContext glxSharedContext);
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
void onPlatformSwapBuffers() const override;
@@ -348,6 +349,12 @@
return context;
}
+void GLXGLTestContext::onPlatformMakeNotCurrent() const {
+ if (!glXMakeCurrent(fDisplay, None , nullptr)) {
+ SkDebugf("Could not reset the context.\n");
+ }
+}
+
void GLXGLTestContext::onPlatformMakeCurrent() const {
if (!glXMakeCurrent(fDisplay, fGlxPixmap, fContext)) {
SkDebugf("Could not set the context.\n");
diff --git a/tools/gpu/gl/iOS/CreatePlatformGLTestContext_iOS.mm b/tools/gpu/gl/iOS/CreatePlatformGLTestContext_iOS.mm
index 0605fdf..ed64d3a 100644
--- a/tools/gpu/gl/iOS/CreatePlatformGLTestContext_iOS.mm
+++ b/tools/gpu/gl/iOS/CreatePlatformGLTestContext_iOS.mm
@@ -27,6 +27,7 @@
private:
void destroyGLContext();
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
void onPlatformSwapBuffers() const override;
@@ -94,6 +95,11 @@
}
}
+void IOSGLTestContext::onPlatformMakeNotCurrent() const {
+ if (![EAGLContext setCurrentContext:nil]) {
+ SkDebugf("Could not reset the context.\n");
+ }
+}
void IOSGLTestContext::onPlatformMakeCurrent() const {
if (![EAGLContext setCurrentContext:fEAGLContext]) {
@@ -103,8 +109,8 @@
std::function<void()> IOSGLTestContext::onPlatformGetAutoContextRestore() const {
if ([EAGLContext currentContext] == fEAGLContext) {
- return nullptr;
- }
+ return nullptr;
+ }
return context_restorer();
}
diff --git a/tools/gpu/gl/mac/CreatePlatformGLTestContext_mac.cpp b/tools/gpu/gl/mac/CreatePlatformGLTestContext_mac.cpp
index c27fe24..6830da9 100644
--- a/tools/gpu/gl/mac/CreatePlatformGLTestContext_mac.cpp
+++ b/tools/gpu/gl/mac/CreatePlatformGLTestContext_mac.cpp
@@ -28,6 +28,7 @@
private:
void destroyGLContext();
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
void onPlatformSwapBuffers() const override;
@@ -106,6 +107,10 @@
}
}
+void MacGLTestContext::onPlatformMakeNotCurrent() const {
+ CGLSetCurrentContext(nullptr);
+}
+
void MacGLTestContext::onPlatformMakeCurrent() const {
CGLSetCurrentContext(fContext);
}
diff --git a/tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp b/tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp
index 7159c13..8d81548 100644
--- a/tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp
+++ b/tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp
@@ -40,6 +40,7 @@
private:
void destroyGLContext();
+ void onPlatformMakeNotCurrent() const override;
void onPlatformMakeCurrent() const override;
std::function<void()> onPlatformGetAutoContextRestore() const override;
void onPlatformSwapBuffers() const override;
@@ -174,6 +175,12 @@
}
}
+void WinGLTestContext::onPlatformMakeNotCurrent() const {
+ if (!wglMakeCurrent(NULL, NULL)) {
+ SkDebugf("Could not null out the rendering context.\n");
+ }
+}
+
void WinGLTestContext::onPlatformMakeCurrent() const {
HDC dc;
HGLRC glrc;
diff --git a/tools/gpu/mock/MockTestContext.cpp b/tools/gpu/mock/MockTestContext.cpp
index f892714..ec53193 100644
--- a/tools/gpu/mock/MockTestContext.cpp
+++ b/tools/gpu/mock/MockTestContext.cpp
@@ -31,6 +31,7 @@
protected:
void teardown() override {}
+ void onPlatformMakeNotCurrent() const override {}
void onPlatformMakeCurrent() const override {}
std::function<void()> onPlatformGetAutoContextRestore() const override { return nullptr; }
void onPlatformSwapBuffers() const override {}
diff --git a/tools/gpu/mtl/MtlTestContext.mm b/tools/gpu/mtl/MtlTestContext.mm
index d5ad079..f7b33b0 100644
--- a/tools/gpu/mtl/MtlTestContext.mm
+++ b/tools/gpu/mtl/MtlTestContext.mm
@@ -108,6 +108,7 @@
fFenceSync.reset(new MtlFenceSync(queue));
}
+ void onPlatformMakeNotCurrent() const override {}
void onPlatformMakeCurrent() const override {}
std::function<void()> onPlatformGetAutoContextRestore() const override { return nullptr; }
void onPlatformSwapBuffers() const override {}
diff --git a/tools/gpu/vk/VkTestContext.cpp b/tools/gpu/vk/VkTestContext.cpp
index 26b23e0..82e2e9c 100644
--- a/tools/gpu/vk/VkTestContext.cpp
+++ b/tools/gpu/vk/VkTestContext.cpp
@@ -249,6 +249,7 @@
fVk.fGraphicsQueueIndex));
}
+ void onPlatformMakeNotCurrent() const override {}
void onPlatformMakeCurrent() const override {}
std::function<void()> onPlatformGetAutoContextRestore() const override { return nullptr; }
void onPlatformSwapBuffers() const override {}
