Return handle when getting simple render pass in vulkan.
We then store this handle on the GrVkFramebuffer. This will be used in
follow on CL to help remove the use of GrVkRenderTarget in the
GrVkOpsRenderPass.
Bug: skia:11809
Change-Id: I979de4e474be1d5e5683dc263fe347cfb63b2342
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/393376
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
diff --git a/src/gpu/vk/GrVkCaps.cpp b/src/gpu/vk/GrVkCaps.cpp
index 7024065..ad5b863 100644
--- a/src/gpu/vk/GrVkCaps.cpp
+++ b/src/gpu/vk/GrVkCaps.cpp
@@ -1842,8 +1842,8 @@
bool needsStencil = programInfo.numStencilSamples() || programInfo.isStencilEnabled();
// TODO: support failure in getSimpleRenderPass
- const GrVkRenderPass* rp = vkRT->getSimpleRenderPass(needsResolve, needsStencil,
- selfDepFlags, loadFromResolve);
+ auto[rp, compatibleHandle] = vkRT->getSimpleRenderPass(needsResolve, needsStencil,
+ selfDepFlags, loadFromResolve);
SkASSERT(rp);
rp->genKey(&b);
diff --git a/src/gpu/vk/GrVkFramebuffer.cpp b/src/gpu/vk/GrVkFramebuffer.cpp
index 7a3c1a1..e2170bc 100644
--- a/src/gpu/vk/GrVkFramebuffer.cpp
+++ b/src/gpu/vk/GrVkFramebuffer.cpp
@@ -12,12 +12,14 @@
#include "src/gpu/vk/GrVkImageView.h"
#include "src/gpu/vk/GrVkRenderPass.h"
-GrVkFramebuffer* GrVkFramebuffer::Create(GrVkGpu* gpu,
- int width, int height,
- const GrVkRenderPass* renderPass,
- const GrVkAttachment* colorAttachment,
- const GrVkAttachment* resolveAttachment,
- const GrVkAttachment* stencilAttachment) {
+GrVkFramebuffer* GrVkFramebuffer::Create(
+ GrVkGpu* gpu,
+ int width, int height,
+ const GrVkRenderPass* renderPass,
+ const GrVkAttachment* colorAttachment,
+ const GrVkAttachment* resolveAttachment,
+ const GrVkAttachment* stencilAttachment,
+ GrVkResourceProvider::CompatibleRPHandle compatibleRenderPassHandle) {
// At the very least we need a renderPass and a colorAttachment
SkASSERT(renderPass);
SkASSERT(colorAttachment);
@@ -53,7 +55,8 @@
}
return new GrVkFramebuffer(gpu, framebuffer, sk_ref_sp(colorAttachment),
- sk_ref_sp(resolveAttachment), sk_ref_sp(stencilAttachment));
+ sk_ref_sp(resolveAttachment), sk_ref_sp(stencilAttachment),
+ compatibleRenderPassHandle);
}
GrVkFramebuffer::~GrVkFramebuffer() {}
diff --git a/src/gpu/vk/GrVkFramebuffer.h b/src/gpu/vk/GrVkFramebuffer.h
index 11e0905..2f1aa19 100644
--- a/src/gpu/vk/GrVkFramebuffer.h
+++ b/src/gpu/vk/GrVkFramebuffer.h
@@ -11,6 +11,7 @@
#include "include/gpu/GrTypes.h"
#include "include/gpu/vk/GrVkTypes.h"
#include "src/gpu/vk/GrVkManagedResource.h"
+#include "src/gpu/vk/GrVkResourceProvider.h"
class GrVkAttachment;
class GrVkGpu;
@@ -24,7 +25,8 @@
const GrVkRenderPass* renderPass,
const GrVkAttachment* colorAttachment,
const GrVkAttachment* resolveAttachment,
- const GrVkAttachment* stencilAttachment);
+ const GrVkAttachment* stencilAttachment,
+ GrVkResourceProvider::CompatibleRPHandle);
VkFramebuffer framebuffer() const { return fFramebuffer; }
@@ -34,17 +36,23 @@
}
#endif
+ GrVkResourceProvider::CompatibleRPHandle compatibleRenderPassHandle() const {
+ return fCompatibleRenderPassHandle;
+ }
+
private:
GrVkFramebuffer(const GrVkGpu* gpu,
VkFramebuffer framebuffer,
sk_sp<GrVkAttachment> colorAttachment,
sk_sp<GrVkAttachment> resolveAttachment,
- sk_sp<GrVkAttachment> stencilAttachment)
+ sk_sp<GrVkAttachment> stencilAttachment,
+ GrVkResourceProvider::CompatibleRPHandle compatibleRenderPassHandle)
: INHERITED(gpu)
, fFramebuffer(framebuffer)
, fColorAttachment(std::move(colorAttachment))
, fResolveAttachment(std::move(resolveAttachment))
- , fStencilAttachment(std::move(stencilAttachment)) {}
+ , fStencilAttachment(std::move(stencilAttachment))
+ , fCompatibleRenderPassHandle(compatibleRenderPassHandle) {}
~GrVkFramebuffer() override;
@@ -56,6 +64,8 @@
sk_sp<const GrVkAttachment> fResolveAttachment;
sk_sp<const GrVkAttachment> fStencilAttachment;
+ GrVkResourceProvider::CompatibleRPHandle fCompatibleRenderPassHandle;
+
using INHERITED = GrVkManagedResource;
};
diff --git a/src/gpu/vk/GrVkRenderTarget.cpp b/src/gpu/vk/GrVkRenderTarget.cpp
index ad07203..6dc077a 100644
--- a/src/gpu/vk/GrVkRenderTarget.cpp
+++ b/src/gpu/vk/GrVkRenderTarget.cpp
@@ -226,18 +226,27 @@
return *pRPHandle;
}
-const GrVkRenderPass* GrVkRenderTarget::getSimpleRenderPass(bool withResolve,
- bool withStencil,
- SelfDependencyFlags selfDepFlags,
- LoadFromResolve loadFromResolve) {
+std::pair<const GrVkRenderPass*, GrVkResourceProvider::CompatibleRPHandle>
+ GrVkRenderTarget::getSimpleRenderPass(bool withResolve,
+ bool withStencil,
+ SelfDependencyFlags selfDepFlags,
+ LoadFromResolve loadFromResolve) {
int cacheIndex = renderpass_features_to_index(withResolve, withStencil, selfDepFlags,
loadFromResolve);
SkASSERT(cacheIndex < GrVkRenderTarget::kNumCachedRenderPasses);
- if (const GrVkRenderPass* rp = fCachedRenderPasses[cacheIndex]) {
- return rp;
+ const GrVkRenderPass* rp = fCachedRenderPasses[cacheIndex];
+ if (this->wrapsSecondaryCommandBuffer()) {
+ SkASSERT(rp);
+ // The compatible handle is invalid for external render passes used in wrapped secondary
+ // command buffers. However, this should not be called by code using external render passes
+ // that needs to use the handle.
+ return {rp, GrVkResourceProvider::CompatibleRPHandle()};
}
-
- return this->createSimpleRenderPass(withResolve, withStencil, selfDepFlags, loadFromResolve);
+ if (!rp) {
+ rp = this->createSimpleRenderPass(withResolve, withStencil, selfDepFlags, loadFromResolve);
+ }
+ SkASSERT(!rp || fCompatibleRPHandles[cacheIndex].isValid());
+ return {rp, fCompatibleRPHandles[cacheIndex]};
}
const GrVkRenderPass* GrVkRenderTarget::createSimpleRenderPass(bool withResolve,
@@ -278,11 +287,12 @@
SkASSERT(!this->wrapsSecondaryCommandBuffer());
GrVkGpu* gpu = this->getVkGpu();
- const GrVkRenderPass* renderPass =
+ auto[renderPass, compatibleHandle] =
this->getSimpleRenderPass(withResolve, withStencil, selfDepFlags, loadFromResolve);
if (!renderPass) {
return nullptr;
}
+ SkASSERT(compatibleHandle.isValid());
int cacheIndex =
renderpass_features_to_index(withResolve, withStencil, selfDepFlags, loadFromResolve);
@@ -296,7 +306,7 @@
: nullptr;
fCachedFramebuffers[cacheIndex] =
GrVkFramebuffer::Create(gpu, this->width(), this->height(), renderPass,
- this->colorAttachment(), resolve, stencil);
+ this->colorAttachment(), resolve, stencil, compatibleHandle);
return fCachedFramebuffers[cacheIndex];
}
diff --git a/src/gpu/vk/GrVkRenderTarget.h b/src/gpu/vk/GrVkRenderTarget.h
index a520f6c..bb2c047 100644
--- a/src/gpu/vk/GrVkRenderTarget.h
+++ b/src/gpu/vk/GrVkRenderTarget.h
@@ -74,10 +74,11 @@
return fResolveAttachment ? fResolveAttachment.get() : fColorAttachment.get();
}
- const GrVkRenderPass* getSimpleRenderPass(bool withResolve,
- bool withStencil,
- SelfDependencyFlags selfDepFlags,
- LoadFromResolve);
+ std::pair<const GrVkRenderPass*, GrVkResourceProvider::CompatibleRPHandle> getSimpleRenderPass(
+ bool withResolve,
+ bool withStencil,
+ SelfDependencyFlags selfDepFlags,
+ LoadFromResolve);
GrVkResourceProvider::CompatibleRPHandle compatibleRenderPassHandle(
bool withResolve,
bool withStencil,
