commit a454bfcdca9d2e023965d1d9f02d4c17b894caaf
author Herb Derby <herb@google.com> Thu Oct 06 14:55:31 2022 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Thu Oct 06 19:49:29 2022 +0000
tree f965b336160d30a924b3adce3c72c2f4a13583c3
parent b54966c7d211848cfed7884a5b92fb2f159a2526

Note the performance enhancement in sk_free

This mainly affected armv7 devices with some larger
regressions around 15%. The other platforms where much smaller
at around 3%.

Change-Id: Iee9ac7b2f707035f45cdc581fc45a265c7ecf16d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/588578
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>

src/ports/SkMemory_malloc.cpp

diff --git a/src/ports/SkMemory_malloc.cpp b/src/ports/SkMemory_malloc.cpp
index 49dafdb..6a1c3a9 100644
--- a/src/ports/SkMemory_malloc.cpp
+++ b/src/ports/SkMemory_malloc.cpp
@@ -69,7 +69,9 @@
 }
 
 void sk_free(void* p) {
-    if (p) {
+    // The guard here produces a performance improvement across many tests, and many platforms.
+    // Removing the check was tried in skia cl 588037.
+    if (p != nullptr) {
         free(p);
     }
 }