commit 98ac0f9dbd55c31172ea20cb90b177e80221a89b
author Greg Kaiser <gkaiser@google.com> Fri Jul 12 05:53:12 2019 -0700
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jul 12 13:42:14 2019 +0000
tree 399dc772b07262bc59471c65fa83cc4d8bccd25b
parent 69f1338cc9b86aa7dfbfa26a9a98f77563e21f78

GrGLGpu: Fix typo in 'if' check

We were checking 'externalType' twice, and never checking
'internalFormat'.  We now check each of them once.

Change-Id: Iae0578a4828fd2a9224e4924245bea0708d8c931
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227028
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

src/gpu/gl/GrGLGpu.cpp

diff --git a/src/gpu/gl/GrGLGpu.cpp b/src/gpu/gl/GrGLGpu.cpp
index 4e0ce88..1c134f2 100644
--- a/src/gpu/gl/GrGLGpu.cpp
+++ b/src/gpu/gl/GrGLGpu.cpp
@@ -1619,7 +1619,7 @@
         GrGLenum internalFormat = this->glCaps().getTexImageInternalFormat(format);
         GrGLenum externalFormat = this->glCaps().getBaseInternalFormat(format);
         GrGLenum externalType   = this->glCaps().getFormatDefaultExternalType(format);
-        if (!externalFormat || !externalType || !externalType) {
+        if (!internalFormat || !externalFormat || !externalType) {
             return -1;
         }