commit 81a942c1284776549466ec4dd74a29d71d6052a1
author Brian Salomon <bsalomon@google.com> Tue Sep 15 15:56:43 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Sep 15 20:31:11 2020 +0000
tree 1d55c6d560a9e211c0f38728df3a28dd9a47b29d
parent 31bf3d9bb57a156b60dac7874c3b89d952985d83

SkYUVAPixmaps::toLegacy() init unused mapping for missing alpha channel

Avoids uninit memory down the line. This wouldn't have cause incorrect
rendering but potentially could have eliminated a batching opportunity.

Change-Id: I5494f13f4a56418f6686d956db4b44ce239f2533
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317205
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

src/core/SkYUVAPixmaps.cpp

diff --git a/src/core/SkYUVAPixmaps.cpp b/src/core/SkYUVAPixmaps.cpp
index afd015a..5220003 100644
--- a/src/core/SkYUVAPixmaps.cpp
+++ b/src/core/SkYUVAPixmaps.cpp
@@ -289,6 +289,7 @@
             yuvaIndices[SkYUVAIndex::kY_Index].fChannel = getIthChannel(cts[0], 0);
             yuvaIndices[SkYUVAIndex::kU_Index].fChannel = getIthChannel(cts[1], 0);
             yuvaIndices[SkYUVAIndex::kV_Index].fChannel = getIthChannel(cts[2], 0);
+            yuvaIndices[SkYUVAIndex::kA_Index].fChannel = SkColorChannel::kR; // arbitrary
             break;
     }
     if (!ok) {