commit 7cbe66b334401a658c6bca5d698dcc236136f37b
author John Stiles <johnstiles@google.com> Wed May 12 17:01:23 2021 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu May 13 17:40:13 2021 +0000
tree 0d2925161e6d06a2ef3ce1bda1a969a2c93a9caa
parent 0cfe5e1628128e661f60928c2792349ea921f764

Cleanup operator conversion from assignment to non-assignment form.

We don't need to do string manipulation to turn `+=` into `+`. We can
make the same conversion via `op.removeAssignment()`.

Change-Id: I036ad314c161af45624efecde944bb0e596c1abd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/407816
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>

src/sksl/codegen/SkSLMetalCodeGenerator.cpp

diff --git a/src/sksl/codegen/SkSLMetalCodeGenerator.cpp b/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
index a08133e..79bea71 100644
--- a/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
+++ b/src/sksl/codegen/SkSLMetalCodeGenerator.cpp
@@ -1412,9 +1412,7 @@
         this->write(" = ");
         this->writeExpression(left, Precedence::kAssignment);
         this->write(" ");
-        String opName = OperatorName(op);
-        SkASSERT(opName.endsWith("="));
-        this->write(opName.substr(0, opName.size() - 1).c_str());
+        this->write(OperatorName(op.removeAssignment()));
         this->write(" ");
     } else {
         this->write(String(" ") + OperatorName(op) + " ");