commit 747b3409bc2d99f9cba9c9349eaae53e0da5e21b
author Brian Salomon <bsalomon@google.com> Mon Sep 16 17:25:01 2019 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Sep 17 13:10:43 2019 +0000
tree 4244f30a3feacafc5e5936733be7656fe895824e
parent d545bfbb94ca919e4703d5795ed2351cb779585a

Fix bug where coverage on interior of stroked rects is applied twice

When we were not supposed to be folding coverage into alpha we would still
set the innermost rectangle's color to transparent black.

Change-Id: Idfc29da9778f9d7d0381a8084717134e835dc744
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241882
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

src/gpu/ops/GrStrokeRectOp.cpp

diff --git a/src/gpu/ops/GrStrokeRectOp.cpp b/src/gpu/ops/GrStrokeRectOp.cpp
index 1e07966..9923a1b 100644
--- a/src/gpu/ops/GrStrokeRectOp.cpp
+++ b/src/gpu/ops/GrStrokeRectOp.cpp
@@ -724,7 +724,7 @@
 
         // The innermost rect has 0 coverage...
         vertices.writeQuad(inset_fan(devInside, SK_ScalarHalf, SK_ScalarHalf),
-                           GrVertexColor(SK_PMColor4fTRANSPARENT, wideColor),
+                           outerColor,
                            maybe_coverage(0.0f));
     } else {
         // When the interior rect has become degenerate we smoosh to a single point