commit 746473b904e33715a8b148047eedb7aeb2facb0e
author Mike Klein <mtklein@google.com> Thu Jun 04 11:38:43 2020 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jun 05 12:00:09 2020 +0000
tree 729683de11b065c95b0c6aece75257bbfca42b64
parent ddb6fc24f3f0091543360e0267bdfa598138b4b9

remove sse4.1 opts level

This has become a weird target to optimize for.  It's not hugely better
than SSE2, and AVX2 is common nowadays, so SSE4.1's sweet spot is small.

Change-Id: I31c62fb371a4902f084f78309e7a43955f1fc0c2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294320
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>

src/core/SkOpts.cpp

diff --git a/src/core/SkOpts.cpp b/src/core/SkOpts.cpp
index 08f758e..b847c30 100644
--- a/src/core/SkOpts.cpp
+++ b/src/core/SkOpts.cpp
@@ -107,7 +107,6 @@
 
     // Each Init_foo() is defined in src/opts/SkOpts_foo.cpp.
     void Init_ssse3();
-    void Init_sse41();
     void Init_sse42();
     void Init_avx();
     void Init_hsw();
@@ -121,10 +120,6 @@
             if (SkCpu::Supports(SkCpu::SSSE3)) { Init_ssse3(); }
         #endif
 
-        #if SK_CPU_SSE_LEVEL < SK_CPU_SSE_LEVEL_SSE41
-            if (SkCpu::Supports(SkCpu::SSE41)) { Init_sse41(); }
-        #endif
-
         #if SK_CPU_SSE_LEVEL < SK_CPU_SSE_LEVEL_SSE42
             if (SkCpu::Supports(SkCpu::SSE42)) { Init_sse42(); }
         #endif

src/opts/SkOpts_sse41.cpp

diff --git a/src/opts/SkOpts_sse41.cpp b/src/opts/SkOpts_sse41.cpp
index 8e52596..abd4796 100644
--- a/src/opts/SkOpts_sse41.cpp
+++ b/src/opts/SkOpts_sse41.cpp
@@ -5,27 +5,4 @@
  * found in the LICENSE file.
  */
 
-#include "src/core/SkOpts.h"
-
-#define SK_OPTS_NS sse41
-#include "src/opts/SkBlitRow_opts.h"
-#include "src/opts/SkRasterPipeline_opts.h"
-
-namespace SkOpts {
-    void Init_sse41() {
-        blit_row_color32     = sse41::blit_row_color32;
-        blit_row_s32a_opaque = sse41::blit_row_s32a_opaque;
-
-    #define M(st) stages_highp[SkRasterPipeline::st] = (StageFn)SK_OPTS_NS::st;
-        SK_RASTER_PIPELINE_STAGES(M)
-        just_return_highp = (StageFn)SK_OPTS_NS::just_return;
-        start_pipeline_highp = SK_OPTS_NS::start_pipeline;
-    #undef M
-
-    #define M(st) stages_lowp[SkRasterPipeline::st] = (StageFn)SK_OPTS_NS::lowp::st;
-        SK_RASTER_PIPELINE_STAGES(M)
-        just_return_lowp = (StageFn)SK_OPTS_NS::lowp::just_return;
-        start_pipeline_lowp = SK_OPTS_NS::lowp::start_pipeline;
-    #undef M
-    }
-}
+// Intentionally empty, to be cleaned up.