commit 6c11ba23346ec4486860195426016649233bd1ed
author Brian Salomon <bsalomon@google.com> Fri Oct 16 11:11:40 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Oct 16 15:54:02 2020 +0000
tree 965c34a4c6163ebf838c8cb7daa225edcf14b255
parent a0c6731b121abe248565e31e2ecd556d65a44336

fix always true comparison in assert

Bug: skia:10632
Change-Id: I271875a73b7e80a3ef5ea357eab7c8165440e7a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327718
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

tools/gpu/YUVUtils.cpp

diff --git a/tools/gpu/YUVUtils.cpp b/tools/gpu/YUVUtils.cpp
index 93c011b..d5f7ac3 100644
--- a/tools/gpu/YUVUtils.cpp
+++ b/tools/gpu/YUVUtils.cpp
@@ -147,7 +147,7 @@
 sk_sp<SkImage> LazyYUVImage::refImage(GrRecordingContext* rContext, Type type) {
     if (this->ensureYUVImage(rContext, type)) {
         size_t idx = static_cast<size_t>(type);
-        SkASSERT(idx >= 0 && idx < SK_ARRAY_COUNT(fYUVImage));
+        SkASSERT(idx < SK_ARRAY_COUNT(fYUVImage));
         return fYUVImage[idx];
     } else {
         return nullptr;
@@ -197,7 +197,7 @@
 
 bool LazyYUVImage::ensureYUVImage(GrRecordingContext* rContext, Type type) {
     size_t idx = static_cast<size_t>(type);
-    SkASSERT(idx >= 0 && idx < SK_ARRAY_COUNT(fYUVImage));
+    SkASSERT(idx < SK_ARRAY_COUNT(fYUVImage));
     if (fYUVImage[idx] && fYUVImage[idx]->isValid(rContext)) {
         return true;  // Have already made a YUV image valid for this context.
     }