commit 431f305d513e2cc5cf4ea87d9f423c9840fc2e99
author John Stiles <johnstiles@google.com> Mon May 16 10:50:47 2022 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Mon May 16 15:53:02 2022 +0000
tree ad3711467ab5dc2e642ce38c82f62acc6197cdce
parent c4abee5e385b87c5a85da701d0f457244b2d7f32

Remove useless std::move.

This doesn't do anything, but if it did, it would cause a
use-after-move.

Change-Id: Idfb515ac0a8395c7a4ff86f9fcf25a96c336527d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/540860
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>

src/sksl/SkSLCompiler.cpp

diff --git a/src/sksl/SkSLCompiler.cpp b/src/sksl/SkSLCompiler.cpp
index 7d3cf6b..bbd5c24 100644
--- a/src/sksl/SkSLCompiler.cpp
+++ b/src/sksl/SkSLCompiler.cpp
@@ -395,7 +395,7 @@
     }
     ParsedModule baseModule = {std::move(base), /*fElements=*/nullptr};
     LoadedModule module = DSLParser(this, settings, kind, std::move(text))
-                                  .moduleInheritingFrom(std::move(baseModule));
+                                  .moduleInheritingFrom(baseModule);
     if (this->errorCount()) {
         printf("Unexpected errors: %s\n", this->fErrorText.c_str());
         SkDEBUGFAILF("%s %s\n", data.fPath, this->fErrorText.c_str());