commit 4156d33568274e383934c254a6a119a18152ef66
author Brian Osman <brianosman@google.com> Wed Feb 19 09:40:35 2020 -0500
committer Brian Osman <brianosman@google.com> Wed Feb 19 14:52:48 2020 +0000
tree 71c309189cf8e487e8c293cb91d4acc66d730612
parent 86b4388fdcb441e09c95d292dc68662e4a0eb763

Switch SPIRV-Cross to use third_party GN template

Suppresses all warnings (nonportable include paths, etc.)

Change-Id: Ic1bbf2496a2fe259d5e7a9537e1d89ec74a99add
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271857
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

third_party/spirv-cross/BUILD.gn

diff --git a/third_party/spirv-cross/BUILD.gn b/third_party/spirv-cross/BUILD.gn
index 8877e66..4e78518 100644
--- a/third_party/spirv-cross/BUILD.gn
+++ b/third_party/spirv-cross/BUILD.gn
@@ -1,27 +1,13 @@
+import("../third_party.gni")
+
 spirv_cross = "//third_party/externals/spirv-cross"
 
-config("spirv_cross_config") {
-  include_dirs = [
+third_party("spirv_cross") {
+  public_include_dirs = [
     "//third_party/externals",
     "//third_party/externals/spirv-cross",
   ]
-  defines = [ "SPIRV_CROSS_EXCEPTIONS_TO_ASSERTIONS" ]
-}
-
-static_library("spirv_cross") {
-  public_configs = [ ":spirv_cross_config" ]
-  configs -= [ "//gn:warnings" ]
-
-  cflags = []
-  if (is_win) {
-    cflags += [
-      "/wd5850",
-      "/wd4245",
-      "/wd4702",
-      "/wd4706",
-      "/wd4715",
-    ]
-  }
+  public_defines = [ "SPIRV_CROSS_EXCEPTIONS_TO_ASSERTIONS" ]
 
   sources = rebase_path([
                           "GLSL.std.450.h",