commit 2ee498c6749a42e71707a054683e43a84cf10d82
author Ethan Nicholas <ethannicholas@google.com> Fri Jan 11 15:32:05 2019 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Sat Jan 12 14:30:06 2019 +0000
tree f7735bf8d253932d619548df1c0d5def0bca7b47
parent f855c3c785bb783446b00b7b8fad02be6b1bf465

fixed uninitialized value in Perlin noise shader

Bug: skia:
Change-Id: Ie1670dd574b19faa396c8db1a58cfe922925ae5a
Reviewed-on: https://skia-review.googlesource.com/c/183386
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

src/shaders/SkPerlinNoiseShader.cpp

diff --git a/src/shaders/SkPerlinNoiseShader.cpp b/src/shaders/SkPerlinNoiseShader.cpp
index 6e90011a..5f4f452 100644
--- a/src/shaders/SkPerlinNoiseShader.cpp
+++ b/src/shaders/SkPerlinNoiseShader.cpp
@@ -103,7 +103,9 @@
                              &tileVec);
 
             SkSize scale;
-            matrix.decomposeScale(&scale, nullptr);
+            if (!matrix.decomposeScale(&scale, nullptr)) {
+                scale.set(SK_ScalarNearlyZero, SK_ScalarNearlyZero);
+            }
             fBaseFrequency.set(baseFrequencyX * SkScalarInvert(scale.width()),
                                baseFrequencyY * SkScalarInvert(scale.height()));
             fTileSize.set(SkScalarRoundToInt(tileVec.fX), SkScalarRoundToInt(tileVec.fY));