commit 2ab2ac03d8eebbb69c0a5a526f2a030fa4da8614
author Brian Osman <brianosman@google.com> Mon Sep 09 13:54:54 2019 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Sep 10 15:30:37 2019 +0000
tree b871613cf3ca1b246d702d501ba1e6df8cbe6572
parent b2d5d40a33935cec42bf5fd735ed666ee698f4c5

GL: Don't leak shader objects when program linking fails

Change-Id: I9e0895811176c795cafd356495802128539e4cab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240278
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/gpu/gl/builders/GrGLProgramBuilder.cpp

diff --git a/src/gpu/gl/builders/GrGLProgramBuilder.cpp b/src/gpu/gl/builders/GrGLProgramBuilder.cpp
index 98b6a88..233e96e 100644
--- a/src/gpu/gl/builders/GrGLProgramBuilder.cpp
+++ b/src/gpu/gl/builders/GrGLProgramBuilder.cpp
@@ -381,7 +381,7 @@
         GL_CALL(LinkProgram(programID));
         if (checkLinked) {
             if (!this->checkLinkStatus(programID, errorHandler, sksl, glsl)) {
-                GL_CALL(DeleteProgram(programID));
+                cleanup_program(fGpu, programID, shadersToDelete);
                 return nullptr;
             }
         }