commit 10af5ecfaa7bd382af630a83b50432ce4f1e44ce
author Mike Klein <mtklein@google.com> Mon Feb 11 12:18:24 2019 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Feb 11 18:34:32 2019 +0000
tree d9af60fae643b2af07ff829fbe9019bc50604998
parent 27f830257b830df4cd15b3abac16d22680fd2873

use /imsvc with clang-cl where we use -isystem

This should disable warnings from third-party headers
on Clang/Win builds.  So far we've just gotten lucky.

Change-Id: Ieaf459e200925d46d8c65ba8d489db111705b125
Reviewed-on: https://skia-review.googlesource.com/c/191283
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

third_party/third_party.gni

diff --git a/third_party/third_party.gni b/third_party/third_party.gni
index 3c1059a..e35c3ec 100644
--- a/third_party/third_party.gni
+++ b/third_party/third_party.gni
@@ -11,8 +11,15 @@
       if (defined(invoker.public_defines)) {
         defines = invoker.public_defines
       }
-      if (is_win) {
+      if (is_win && !is_clang) {
         include_dirs = invoker.public_include_dirs
+      } else if (is_win && is_clang) {
+        foreach(dir, invoker.public_include_dirs) {
+          cflags += [
+            "/imsvc",
+            rebase_path(dir),
+          ]
+        }
       } else {
         foreach(dir, invoker.public_include_dirs) {
           cflags += [