commit 52d192e2b5345c52ceba6dea4366c4d069850970
author Peter Edberg <pedberg@unicode.org> Mon Apr 08 11:48:06 2019 -0700
committer pedberg-icu <42151464+pedberg-icu@users.noreply.github.com> Mon Apr 08 12:27:32 2019 -0700
tree 89c8c2122e1e37397c385589c7b85f0ff871b92d
parent 2f06d1de558acf84a6790f43b67ca255fbd330f4

ICU-20537 jaEra: fix leak in SimpleDateFormat::applyPattern

icu4c/source/i18n/smpdtfmt.cpp

diff --git a/icu4c/source/i18n/smpdtfmt.cpp b/icu4c/source/i18n/smpdtfmt.cpp
index 4a2ccb7..e67c453 100644
--- a/icu4c/source/i18n/smpdtfmt.cpp
+++ b/icu4c/source/i18n/smpdtfmt.cpp
@@ -3909,13 +3909,13 @@
             if (fSharedNumberFormatters != NULL) {
                 Locale ovrLoc(fLocale.getLanguage(),fLocale.getCountry(),fLocale.getVariant(),"numbers=jpanyear");
                 UErrorCode status = U_ZERO_ERROR;
-                const SharedNumberFormat *snf = NULL;
-                SharedObject::copyPtr(createSharedNumberFormat(ovrLoc, status), snf);
+                const SharedNumberFormat *snf = createSharedNumberFormat(ovrLoc, status);
                 if (U_SUCCESS(status)) {
                     // Now that we have an appropriate number formatter, fill in the
                     // appropriate slot in the number formatters table.
                     UDateFormatField patternCharIndex = DateFormatSymbols::getPatternCharIndex(u'y');
                     SharedObject::copyPtr(snf, fSharedNumberFormatters[patternCharIndex]);
+                    snf->deleteIfZeroRefCount();
                     fDateOverride.setTo(u"y=jpanyear", -1); // record status
                 }
             }