commit 79ae6d3bf616732fd4ad07451380366c2e2735b9
author omar <omarcornut@gmail.com> Tue Jul 31 13:36:06 2018 +0200
committer omar <omarcornut@gmail.com> Tue Jul 31 13:45:25 2018 +0200
tree 28b18c454a055d26cdc59a83b7dae484184d8eb9
parent e13e5982ffc61cb83fa90e897dbc9f28ff06c3be

Drag and Drop: Clear payload buffers more consistently in ClearDragAndDrop() + BeginDragDropTargetCustom() can't succeed with hidden contents. (#143)

imgui.cpp

diff --git a/imgui.cpp b/imgui.cpp
index 5b99a98..05efb70 100644
--- a/imgui.cpp
+++ b/imgui.cpp
@@ -4444,11 +4444,7 @@
 
     // Drag and Drop: Elapse payload at the end of the frame if mouse has been released
     if (g.DragDropActive && g.DragDropPayload.DataFrameCount + 1 < g.FrameCount && !IsMouseDown(g.DragDropMouseButton))
-    {
         ClearDragDrop();
-        g.DragDropPayloadBufHeap.clear();
-        memset(&g.DragDropPayloadBufLocal, 0, sizeof(g.DragDropPayloadBufLocal));
-    }
 
     // Drag and Drop: Fallback for source tooltip. This is not ideal but better than nothing.
     if (g.DragDropActive && g.DragDropSourceFrameCount < g.FrameCount)
@@ -13629,6 +13625,9 @@
     g.DragDropAcceptIdCurr = g.DragDropAcceptIdPrev = 0;
     g.DragDropAcceptIdCurrRectSurface = FLT_MAX;
     g.DragDropAcceptFrameCount = -1;
+
+    g.DragDropPayloadBufHeap.clear();
+    memset(&g.DragDropPayloadBufLocal, 0, sizeof(g.DragDropPayloadBufLocal));
 }
 
 // Call when current ID is active.
@@ -13802,6 +13801,8 @@
     IM_ASSERT(id != 0);
     if (!IsMouseHoveringRect(bb.Min, bb.Max) || (id == g.DragDropPayload.SourceId))
         return false;
+    if (window->SkipItems)
+        return false;
 
     IM_ASSERT(g.DragDropWithinSourceOrTarget == false);
     g.DragDropTargetRect = bb;