remove warnings of pvs stduio
diff --git a/xbyak/xbyak.h b/xbyak/xbyak.h
index 2914105..214fb08 100644
--- a/xbyak/xbyak.h
+++ b/xbyak/xbyak.h
@@ -244,7 +244,7 @@
}
};
-inline const char *ConvertErrorToString(Error err)
+inline const char *ConvertErrorToString(const Error& err)
{
return err.what();
}
@@ -749,7 +749,7 @@
}
// 2nd parameter for constructor of CodeArray(maxSize, userPtr, alloc)
-void *const AutoGrow = (void*)1;
+void *const AutoGrow = (void*)1; //-V566
class CodeArray {
enum Type {
@@ -854,14 +854,14 @@
}
top_[size_++] = static_cast<uint8>(code);
}
- void db(const uint8 *code, int codeSize)
+ void db(const uint8 *code, size_t codeSize)
{
- for (int i = 0; i < codeSize; i++) db(code[i]);
+ for (size_t i = 0; i < codeSize; i++) db(code[i]);
}
- void db(uint64 code, int codeSize)
+ void db(uint64 code, size_t codeSize)
{
if (codeSize > 8) throw Error(ERR_BAD_PARAMETER);
- for (int i = 0; i < codeSize; i++) db(static_cast<uint8>(code >> (i * 8)));
+ for (size_t i = 0; i < codeSize; i++) db(static_cast<uint8>(code >> (i * 8)));
}
void dw(uint32 code) { db(code, 2); }
void dd(uint32 code) { db(code, 4); }
@@ -2382,7 +2382,7 @@
if (x == 1) return;
if (x < 1 || (x & (x - 1))) throw Error(ERR_BAD_ALIGN);
if (isAutoGrow() && x > (int)inner::ALIGN_PAGE_SIZE) fprintf(stderr, "warning:autoGrow mode does not support %d align\n", x);
- while (size_t(getCurr()) % x) {
+ while (size_t(getCurr()) % size_t(x) > 0) {
nop();
}
}
diff --git a/xbyak/xbyak_util.h b/xbyak/xbyak_util.h
index 5ba6267..e54f30d 100644
--- a/xbyak/xbyak_util.h
+++ b/xbyak/xbyak_util.h
@@ -316,9 +316,13 @@
Pack(const Pack& rhs)
: n_(rhs.n_)
{
- if (n_ > maxTblNum) throw Error(ERR_INTERNAL);
for (size_t i = 0; i < n_; i++) tbl_[i] = rhs.tbl_[i];
}
+ Pack& operator=(const Pack& rhs)
+ {
+ for (size_t i = 0; i < n_; i++) tbl_[i] = rhs.tbl_[i];
+ return *this;
+ }
Pack(const Xbyak::Reg64& t0)
{ n_ = 1; tbl_[0] = &t0; }
Pack(const Xbyak::Reg64& t1, const Xbyak::Reg64& t0)
@@ -341,7 +345,7 @@
{ n_ = 10; tbl_[0] = &t0; tbl_[1] = &t1; tbl_[2] = &t2; tbl_[3] = &t3; tbl_[4] = &t4; tbl_[5] = &t5; tbl_[6] = &t6; tbl_[7] = &t7; tbl_[8] = &t8; tbl_[9] = &t9; }
Pack& append(const Xbyak::Reg64& t)
{
- if (n_ == 10) {
+ if (n_ == maxTblNum) {
fprintf(stderr, "ERR Pack::can't append\n");
throw Error(ERR_BAD_PARAMETER);
}