| commit | 9be0c61e79147897bd88d45826870f320cf276ea | [log] [tgz] |
|---|---|---|
| author | Sam Lantinga <slouken@libsdl.org> | Tue Apr 14 09:55:33 2020 -0700 |
| committer | Sam Lantinga <slouken@libsdl.org> | Tue Apr 14 09:55:33 2020 -0700 |
| tree | 7c6b938bb1a76063e6f8ebdfab80bdba20360c8a | |
| parent | 72213d6aad2dc5c36a411a74d415d8c1d750e861 [diff] |
Fixed bug 5091 - Suspicious condition in HIDAPI_DriverXbox360_UpdateXInput meyraud705 On line 220 of SDL_hidapi_xbox360.c https://hg.libsdl.org/SDL/file/d0ef8ec6a2eb/src/joystick/hidapi/SDL_hidapi_xbox360.c#l220 if (!XINPUTGETSTATE(user_index, &xinput_state[user_index].state) == ERROR_SUCCESS) { logical not is only applied to the left hand side of this comparison. I think you mean: if (XINPUTGETSTATE(user_index, &xinput_state[user_index].state) != ERROR_SUCCESS) {