commit d57ceff195f5d02504d7adf7396defc915272b67
author Albert Astals Cid <aacid@kde.org> Thu Feb 28 16:52:58 2019 +0100
committer Albert Astals Cid <aacid@kde.org> Thu Feb 28 17:33:54 2019 +0100
tree a0cf0cbe2ece837111ed4c0f36fb61f05d276308
parent 008431647c573d342f07f2e05123bdce938802a3

Gfx: Save unneeded copy() calls

poppler/Gfx.cc

diff --git a/poppler/Gfx.cc b/poppler/Gfx.cc
index 4da19c1..9244b04 100644
--- a/poppler/Gfx.cc
+++ b/poppler/Gfx.cc
@@ -4214,7 +4214,6 @@
   bool maskInvert;
   bool maskInterpolate;
   Stream *maskStr;
-  Object obj1;
   int i, n;
 
   // get info from the stream
@@ -4227,14 +4226,14 @@
 
   // check for optional content key
   if (ref) {
-    obj1 = dict->lookupNF("OC").copy();
-    if (catalog->getOptContentConfig() && !catalog->getOptContentConfig()->optContentIsVisible(&obj1)) {
+    const Object &objOC = dict->lookupNF("OC");
+    if (catalog->getOptContentConfig() && !catalog->getOptContentConfig()->optContentIsVisible(&objOC)) {
       return;
     }
   }
 
   // get size
-  obj1 = dict->lookup("Width");
+  Object obj1 = dict->lookup("Width");
   if (obj1.isNull()) {
     obj1 = dict->lookup("W");
   }
@@ -4691,8 +4690,8 @@
 
   // check for optional content key
   ocSaved = ocState;
-  obj1 = dict->lookupNF("OC").copy();
-  if (catalog->getOptContentConfig() && !catalog->getOptContentConfig()->optContentIsVisible(&obj1)) {
+  const Object &objOC = dict->lookupNF("OC");
+  if (catalog->getOptContentConfig() && !catalog->getOptContentConfig()->optContentIsVisible(&objOC)) {
     if (out->needCharCount()) {
       ocState = false;
     } else {