commit 7ba975630e12a3242d73372a685e016101c5e479
author Jakub Kucharski <jakubkucharski97@gmail.com> Mon Aug 01 01:17:08 2016 +0200
committer Albert Astals Cid <aacid@kde.org> Mon Aug 01 23:05:20 2016 +0200
tree 93ea7ade4275c615b4afee581a36f96b370ec70d
parent f0feeed3513899558c59b65f798f294212309486

PDFDoc::setDocInfoStringEntry(): free empty value string

Normally the ownership of value is passed on to the Object class. In case value
is an empty string, it doesn't happen, so we have to free it in order to have
a uniform behaviour managing memory and not to introduce memory leaks.

poppler/PDFDoc.cc

diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
index a51d8b6..f3383fc 100644
--- a/poppler/PDFDoc.cc
+++ b/poppler/PDFDoc.cc
@@ -612,6 +612,9 @@
 void PDFDoc::setDocInfoStringEntry(const char *key, GooString *value)
 {
   GBool removeEntry = !value || value->getLength() == 0;
+  if (removeEntry) {
+    delete value;
+  }
 
   Object infoObj;
   getDocInfo(&infoObj);