commit 099a09c57224a8072d1591c193815e6434178f25
author Albert Astals Cid <aacid@kde.org> Wed Feb 27 15:58:42 2019 +0100
committer Albert Astals Cid <aacid@kde.org> Wed Feb 27 15:58:42 2019 +0100
tree 80d6da4597f5241434a67cd2b8968c959aa22ddc
parent 1005f8ab69ef539bc46ad3fd4d7e610de0204239

pdf-fullrewrite: Save copy() calls

test/pdf-fullrewrite.cc

diff --git a/test/pdf-fullrewrite.cc b/test/pdf-fullrewrite.cc
index d9b8ac3..22b76a3 100644
--- a/test/pdf-fullrewrite.cc
+++ b/test/pdf-fullrewrite.cc
@@ -16,7 +16,7 @@
 #include "utils/parseargs.h"
 
 static bool compareDocuments(PDFDoc *origDoc, PDFDoc *newDoc);
-static bool compareObjects(Object *objA, Object *objB);
+static bool compareObjects(const Object *objA, const Object *objB);
 
 static char ownerPassword[33] = "\001";
 static char userPassword[33] = "\001";
@@ -125,8 +125,8 @@
    * in dictB is also contained in dictA */
   for (int i = 0; i < length; ++i) {
     const char *key = dictA->getKey(i);
-    Object valA = dictA->getValNF(i).copy();
-    Object valB = dictB->lookupNF(key).copy();
+    const Object &valA = dictA->getValNF(i);
+    const Object &valB = dictB->lookupNF(key);
     if (!compareObjects(&valA, &valB))
       return false;
   }
@@ -134,7 +134,7 @@
   return true;
 }
 
-static bool compareObjects(Object *objA, Object *objB)
+static bool compareObjects(const Object *objA, const Object *objB)
 {
   switch (objA->getType()) {
     case objBool:
@@ -197,8 +197,8 @@
           return false;
         } else {
           for (int i = 0; i < length; ++i) {
-            Object elemA = arrayA->getNF(i).copy();
-            Object elemB = arrayB->getNF(i).copy();
+            const Object &elemA = arrayA->getNF(i);
+            const Object &elemB = arrayB->getNF(i);
             if (!compareObjects(&elemA, &elemB)) {
               return false;
             }