commit fc4ee229a653d0e9d71f828e513c9d458c1eab57
author Leon Scroggins III <scroggo@google.com> Fri Jul 14 11:48:52 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jul 14 16:25:54 2017 +0000
tree b84dfc5d2293d4dcb5434e2acd91b27af298f65c
parent 82ddc94aff0c8400a35f8006ee448574347c0c28

Fix double delete in SkBmpCodec

Previously, if ReadHeader returned false, it deleted the input stream.
But there are a couple of cases where ReadHeader creates an SkCodec and
then returns false. The SkCodec deletes the stream, and then so does
NewFromStream.

Make sure that we do not double delete by only deleting if no SkCodec
was created.

Add a test, so such a double delete will be caught by the bots.

Bug: b/37623797
Change-Id: I787422c9af58f0b92ad9e9ef9ad87c54a12f5e31
Reviewed-on: https://skia-review.googlesource.com/23620
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>