Google Git
Sign in
skia / skia / f76259e9cba78cbf17643f964ae16e34cb391950
commitf76259e9cba78cbf17643f964ae16e34cb391950[log] [tgz]
authorGreg Daniel <egdaniel@google.com>Thu Feb 04 12:14:04 2021 -0500
committerSkia Commit-Bot <skia-commit-bot@chromium.org>Thu Feb 04 23:36:19 2021 +0000
treecd597263528cd01ab011992af33d5e9220e37d1b
parentb88b4e1a12acb924556165400f8add2682514ffe [diff]
Make sure to unbind xfer buffer before glReadPixels to cpu call.

If follow on change when I try to use cached buffers for read backs we
get into a state where we're doing normal readPixels but we still have
the buffer alive and it is still bound to PIXEL_PACK_BUFFER which causes
INVALID_OPERATION errors.

Bug: skia:11226
Change-Id: If5486cc2743908ee7222925afb372c1cfafef429
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/366319
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2 files changed
tree: cd597263528cd01ab011992af33d5e9220e37d1b
  1. animations/
  2. bazel/
  3. bench/
  4. bin/
  5. build/
  6. build_overrides/
  7. client_utils/
  8. demos.skia.org/
  9. dm/
  10. docker/
  11. docs/
  12. example/
  13. experimental/
  14. fuzz/
  15. gm/
  16. gn/
  17. include/
  18. infra/
  19. modules/
  20. platform_tools/
  21. resources/
  22. samplecode/
  23. site/
  24. specs/
  25. src/
  26. tests/
  27. third_party/
  28. tools/
  29. .bazelignore
  30. .clang-format
  31. .clang-tidy
  32. .gitignore
  33. .gn
  34. AUTHORS
  35. BUILD.bazel
  36. BUILD.gn
  37. codereview.settings
  38. CONTRIBUTING
  39. CQ_COMMITTERS
  40. DEPS
  41. DIR_METADATA
  42. go.mod
  43. go.sum
  44. LICENSE
  45. PRESUBMIT.py
  46. public.bzl
  47. README
  48. README.chromium
  49. RELEASE_NOTES.txt
  50. whitespace.txt
  51. WORKSPACE.bazel