commit eda5ba159815dba4bab0625c0479b26e924409ed
author Jim Van Verth <jvanverth@google.com> Fri Oct 15 17:25:19 2021 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Mon Oct 18 14:06:02 2021 +0000
tree 0c6097ee18aa2e8661889a1a613088ae066e1c77
parent 67579cbfcd3cbfd3deb06c6d69a72020ee71d4ec

[graphite] Add resource tracking to CommandBuffer

Bug: skia:12466
Change-Id: I98acab4bbab2fdc1c359161956c3f0aa29ad7adc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459884
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

experimental/graphite/src/CommandBuffer.cpp

diff --git a/experimental/graphite/src/CommandBuffer.cpp b/experimental/graphite/src/CommandBuffer.cpp
index df984ba..d80b199 100644
--- a/experimental/graphite/src/CommandBuffer.cpp
+++ b/experimental/graphite/src/CommandBuffer.cpp
@@ -7,8 +7,16 @@
 
 #include "experimental/graphite/src/CommandBuffer.h"
 
+#include "src/core/SkTraceEvent.h"
+
 namespace skgpu {
 
 CommandBuffer::CommandBuffer() {}
 
+void CommandBuffer::releaseResources() {
+    TRACE_EVENT0("skia.gpu", TRACE_FUNC);
+
+    fTrackedResources.reset();
+}
+
 } // namespace skgpu

experimental/graphite/src/CommandBuffer.h

diff --git a/experimental/graphite/src/CommandBuffer.h b/experimental/graphite/src/CommandBuffer.h
index 85d3bd0..572e947 100644
--- a/experimental/graphite/src/CommandBuffer.h
+++ b/experimental/graphite/src/CommandBuffer.h
@@ -9,22 +9,33 @@
 #define skgpu_CommandBuffer_DEFINED
 
 #include "include/core/SkRefCnt.h"
+#include "include/private/SkTArray.h"
 
 namespace skgpu {
 class Gpu;
 
 class CommandBuffer : public SkRefCnt {
 public:
-    ~CommandBuffer() override {}
+    ~CommandBuffer() override {
+        this->releaseResources();
+    }
 
     bool hasWork() { return fHasWork; }
 
 protected:
     CommandBuffer();
 
+    void trackResource(sk_sp<SkRefCnt> resource) {
+        fTrackedResources.push_back(std::move(resource));
+    }
+    void releaseResources();
+
     bool fHasWork = false;
 
 private:
+    static const int kInitialTrackedResourcesCount = 32;
+    SkSTArray<kInitialTrackedResourcesCount, sk_sp<SkRefCnt>> fTrackedResources;
+
 };
 
 } // namespace skgpu

experimental/graphite/src/mtl/MtlCommandBuffer.mm

diff --git a/experimental/graphite/src/mtl/MtlCommandBuffer.mm b/experimental/graphite/src/mtl/MtlCommandBuffer.mm
index d3c7bcb..0933886 100644
--- a/experimental/graphite/src/mtl/MtlCommandBuffer.mm
+++ b/experimental/graphite/src/mtl/MtlCommandBuffer.mm
@@ -51,5 +51,4 @@
     return ((*fCommandBuffer).status != MTLCommandBufferStatusError);
 }
 
-
 } // namespace skgpu::mtl