commit fa71ffaedba2abda92c3a7b456595d893a5f52a8
author Brian Osman <brianosman@google.com> Tue Jan 26 14:05:31 2021 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Jan 27 14:05:39 2021 +0000
tree 151ad26376f7ffa8720fe64b519376b0d5c8eeaf
parent f932c692e59bc3ca58dafaa458e7656ce8140e56

Reland "Fix field access and indexing of complex expressions"

Evaluating either kind of expression now works like all other
expressions - evaluate the inner part, then work with the resulting
values. Added unit tests for both of these that previously failed.

With this change, writeVariableExpression is only used for
VariableReference expressions, so adjust that, too.

Reland now safe, after fix to Value::operator[]

This reverts commit 1ea6d6051e325204516661caee0efd4be4a48ddb.

Bug: skia:11178
Cq-Include-Trybots: luci.skia.skia.primary:Test-Debian10-GCC-GCE-CPU-AVX2-x86-Debug-All-Docker
Change-Id: I14782fcdfef33a47a46334447c5847976721b21f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/359564
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>