commit d0b568b52910712e5a0da32ca73740ec17d4d9a0
author Mike Klein <mtklein@google.com> Mon Mar 30 08:11:15 2020 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Mar 30 13:54:10 2020 +0000
tree 60047019f5790c0d0f8649f839747227b16ed04c
parent 47737a12334cadaec14ec22d811061b4bd32b4e4

remove negate()

negate(x) -> -x

Change-Id: I920b1abe473325309562ca29be6384bedd7e6a42
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280317
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>

src/core/SkVM.h

diff --git a/src/core/SkVM.h b/src/core/SkVM.h
index d8278f9..d4e7472 100644
--- a/src/core/SkVM.h
+++ b/src/core/SkVM.h
@@ -504,9 +504,7 @@
         F32 mad(F32  x, F32  y, F32  z) { return add(mul(x,y), z); }
         F32 mad(F32a x, F32a y, F32a z) { return mad(_(x), _(y), _(z)); }
 
-        F32 negate(F32 x) { return sub(0.0f, x); }
-        F32   sqrt(F32);
-
+        F32        sqrt(F32);
         F32 approx_log2(F32);
         F32 approx_pow2(F32);
         F32 approx_log (F32 x) { return mul(0.69314718f, approx_log2(x)); }
@@ -868,6 +866,9 @@
     static inline F32& operator-=(F32& x, F32a y) { return (x = x - y); }
     static inline F32& operator*=(F32& x, F32a y) { return (x = x * y); }
 
+    static inline I32 operator-(I32 x) { return 0-x; }
+    static inline F32 operator-(F32 x) { return 0-x; }
+
 }
 
 #endif//SkVM_DEFINED

src/shaders/gradients/SkTwoPointConicalGradient.cpp

diff --git a/src/shaders/gradients/SkTwoPointConicalGradient.cpp b/src/shaders/gradients/SkTwoPointConicalGradient.cpp
index e653351..9d3f895 100644
--- a/src/shaders/gradients/SkTwoPointConicalGradient.cpp
+++ b/src/shaders/gradients/SkTwoPointConicalGradient.cpp
@@ -268,7 +268,7 @@
         skvm::F32 k = p->sqrt(p->sub(p->mul(x,x),
                                      p->mul(y,y)));
         if (fFocalData.isSwapped() || 1 - fFocalData.fFocalX < 0) {
-            k = p->negate(k);
+            k = -k;
         }
         t = p->sub(k, p->mul(x, invR1));
     }
@@ -279,7 +279,7 @@
     }
 
     const skvm::F32 focalX = p->uniformF(uniforms->pushF(fFocalData.fFocalX));
-    if (1 - fFocalData.fFocalX < 0)    { t = p->negate(t); }
+    if (1 - fFocalData.fFocalX < 0)    { t = -t; }
     if (!fFocalData.isNativelyFocal()) { t = p->add(t, focalX); }
     if (fFocalData.isSwapped())        { t = p->sub(p->splat(1.0f), t); }
     return t;