bc3c41b8742aa3430b5da0ac97de42f0fe25fe85 - skia

commit	bc3c41b8742aa3430b5da0ac97de42f0fe25fe85	[log] [tgz]
author	John Stiles <johnstiles@google.com>	Fri Dec 04 10:52:40 2020 -0500
committer	Skia Commit-Bot <skia-commit-bot@chromium.org>	Fri Dec 04 19:30:35 2020 +0000
tree	11208102909cc6c0a96afc65c32d97ee863832bb
parent	db873dd600c3e214450c1df6f6f358b9604c9d6d [diff]

Enforce that layout(binding=...) is set on interface blocks in Metal.

Previously, we would emit an invalid [[buffer(-1)]] annotation on the
block, causing the Metal compilation to fail.

Change-Id: I68b2439c05db3163686e84c5dcc9a5c43870ff67
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340761
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>

gn/sksl_tests.gni[diff]
src/sksl/SkSLMetalCodeGenerator.cpp[diff]
tests/sksl/metal/InterfaceBlocksRequireBinding.sksl[Added - diff]
tests/sksl/metal/golden/InterfaceBlocksRequireBinding.metal[Added - diff]
tests/sksl/shared/InterfaceBlockAnonymous.sksl[diff]
tests/sksl/shared/InterfaceBlockArray.sksl[diff]
tests/sksl/shared/InterfaceBlockNamed.sksl[diff]
tests/sksl/shared/golden/InterfaceBlockAnonymous.asm.frag[diff]
tests/sksl/shared/golden/InterfaceBlockAnonymous.glsl[diff]
tests/sksl/shared/golden/InterfaceBlockAnonymous.metal[diff]
tests/sksl/shared/golden/InterfaceBlockArray.asm.frag[diff]
tests/sksl/shared/golden/InterfaceBlockArray.glsl[diff]
tests/sksl/shared/golden/InterfaceBlockArray.metal[diff]
tests/sksl/shared/golden/InterfaceBlockNamed.asm.frag[diff]
tests/sksl/shared/golden/InterfaceBlockNamed.glsl[diff]
tests/sksl/shared/golden/InterfaceBlockNamed.metal[diff]

16 files changed