commit ae59036239d3841822dce9d881396db7415d1a8f
author Robert Phillips <robertphillips@google.com> Tue May 21 10:37:40 2024 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Tue May 21 15:33:07 2024 +0000
tree b8843a49305d407127d0ebe88865b719789eceb5
parent ca98796cc19e4ea0ecc32914f2967f003046a282

Minor cleanup of stray SkScalerContextEffects

afaict these temporary SkScalerContextEffects didn't do anything. Most likely they are copy/paste debris from SkStrikeSpec::createScalerContext, which does use the temporary SkScalerContextEffects objects.

Change-Id: I16373bfbf8456b350ef2ccd0f8aef623fe658167
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/855298
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

src/core/SkStrikeSpec.cpp

diff --git a/src/core/SkStrikeSpec.cpp b/src/core/SkStrikeSpec.cpp
index f827feb..0ff6c35 100644
--- a/src/core/SkStrikeSpec.cpp
+++ b/src/core/SkStrikeSpec.cpp
@@ -173,12 +173,10 @@
 }
 
 sk_sp<SkStrike> SkStrikeSpec::findOrCreateStrike() const {
-    SkScalerContextEffects effects{fPathEffect.get(), fMaskFilter.get()};
     return SkStrikeCache::GlobalStrikeCache()->findOrCreateStrike(*this);
 }
 
 sk_sp<SkStrike> SkStrikeSpec::findOrCreateStrike(SkStrikeCache* cache) const {
-    SkScalerContextEffects effects{fPathEffect.get(), fMaskFilter.get()};
     return cache->findOrCreateStrike(*this);
 }