commit | 656de7fc69941dd1b0888c2907de7a41afb8240c | [log] [tgz] |
---|---|---|
author | John Stiles <johnstiles@google.com> | Fri Jun 02 18:27:22 2023 -0400 |
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Fri Jun 02 23:22:57 2023 +0000 |
tree | 33fc9f7c15498868204b29b5bbe3acd86316a524 | |
parent | a2094b9209efa7800361c1c626f3d8a5904cc4bc [diff] |
Revert "Allow trivial non-constant expressions to use SpvOpSelect." This reverts commit ae3a9bc29d50fd20c8ac47ade61f1fb3e3023bda. Reason for revert: crashing in Programs test in Windows+RTX3060 https://screenshot.googleplex.com/7axduxNfMeVK7gE Original change's description: > Allow trivial non-constant expressions to use SpvOpSelect. > > Previously, we would only use OpSelect when choosing between two > scalar constant values, and in all other cases would convert > ternary expressions to an if-else block. We now also choose > OpSelect for "trivial expressions" (variable references, swizzles, > array accesses, field accesses), and support vectors as well as > scalars. > > This has a wide-reaching impact on our test suite, because most > tests end in `return something ? colorGreen : colorRed;`. This > expression will now use OpSelect. > > (The HLSL expansion of OpSelect is intriguingly bad, but hopefully > this is not an issue in practice.) > > Change-Id: Ia31d42d27b51b801deb17a69c89bff65d949c99d > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/706678 > Auto-Submit: John Stiles <johnstiles@google.com> > Reviewed-by: Arman Uguray <armansito@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> Change-Id: I78ea108827bc3471b07faf7bf009d9d59f41336c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/706917 Commit-Queue: Arman Uguray <armansito@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Auto-Submit: John Stiles <johnstiles@google.com>