Google Git
Sign in
skia / skia / 85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e
commit85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e[log] [tgz]
authorscroggo <scroggo@google.com>Tue Oct 06 10:47:52 2015 -0700
committerCommit bot <commit-bot@chromium.org>Tue Oct 06 10:47:52 2015 -0700
tree1e38add1f4af36a0b8270239775326d5d4116868
parent8b2bc252faed7c751cf9248c3833c0631f498b7d [diff]
Allow SkIcoCodec to fail due to conversion

Even if the client chooses dimensions that were suggested by
SkIcoCodec, it is possible for the color conversion to be incorrect,
so it can still reach the exit case of kInvalidConversion.

For example, when running nanobench, we attempt to decode the image
to Alpha_8, which the codec does not support. This allows running
nanobench in debug mode without asserting.

BUG=skia:3418

Review URL: https://codereview.chromium.org/1389943002
1 file changed
tree: 1e38add1f4af36a0b8270239775326d5d4116868
  1. animations/
  2. bench/
  3. bin/
  4. cmake/
  5. debugger/
  6. dm/
  7. example/
  8. experimental/
  9. forth/
  10. gm/
  11. gyp/
  12. include/
  13. infra/
  14. platform_tools/
  15. resources/
  16. samplecode/
  17. site/
  18. src/
  19. tests/
  20. third_party/
  21. tools/
  22. .gitignore
  23. AUTHORS
  24. BUILD.public
  25. codereview.settings
  26. CONTRIBUTING
  27. CQ_COMMITTERS
  28. DEPS
  29. Doxyfile
  30. gyp_skia
  31. gyp_skia.py
  32. LICENSE
  33. make.bat
  34. make.py
  35. Makefile
  36. OWNERS
  37. PRESUBMIT.py
  38. README
  39. README.chromium
  40. skia.gyp
  41. SKP_VERSION
  42. whitespace.txt