68aeec07de4a1894a5cefde405abcb5a49801df6 - skia

commit	68aeec07de4a1894a5cefde405abcb5a49801df6	[log] [tgz]
author	Brian Salomon <bsalomon@google.com>	Tue Apr 16 11:01:13 2019 -0400
committer	Skia Commit-Bot <skia-commit-bot@chromium.org>	Tue Apr 16 16:52:44 2019 +0000
tree	a61f11ed0d1f343f982f8a76556b04d4d0269cae
parent	c8098329300b4c6421c541d16442ba13dad57c33 [diff]

Clarify that buffers of type GrGpuBufferType::kXferGpuToCpu are mapped for reading.

Don't allow GrGpuBuffer::updateData on kXferGpuToCpu (in GL this can resize the buffer
to a smaller size).

Don't call glBufferData with NULL prior to mapping for reading.

Don't set GL_MAP_WRITE_BIT when using glMapBufferRange for reading only.

Bug: skia:8962
Change-Id: I605d83fa40c7b170082c48a456436d97cf3b70a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206707
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

src/gpu/GrGpuBuffer.cpp[diff]
src/gpu/GrGpuBuffer.h[diff]
src/gpu/gl/GrGLBuffer.cpp[diff]
src/gpu/vk/GrVkIndexBuffer.cpp[diff]
src/gpu/vk/GrVkTransferBuffer.h[diff]

5 files changed

tree: a61f11ed0d1f343f982f8a76556b04d4d0269cae