Google Git
Sign in
skia / skia / 64c8b811b55aeb3c077dac0e32a12a3b40b1c128
commit64c8b811b55aeb3c077dac0e32a12a3b40b1c128[log] [tgz]
authorStephen White <senorblanco@chromium.org>Wed Jun 03 14:05:48 2020 -0400
committerSkia Commit-Bot <skia-commit-bot@chromium.org>Wed Jun 03 18:40:49 2020 +0000
tree478ee2697d472bdaabbc87f98ab5efe76db114d4
parent625dc60e8b4359ba109b297ca455a2c315dd408c [diff]
Dawn: fix memory corruption in DawnTestContext.

Move the dawn_native::Instance ownership from DawnTestContextImpl to
DawnTestContext (its parent class), which owns the wgpu::Device.

dawn_native::Instance must outlive any wgpu::Devices created from it.

Bug: skia: 10311
Change-Id: Iedc4ed94f03b61d5e43cd5c93eb68e24bc4474e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293852
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2 files changed
tree: 478ee2697d472bdaabbc87f98ab5efe76db114d4
  1. animations/
  2. bench/
  3. bin/
  4. build/
  5. build_overrides/
  6. client_utils/
  7. dm/
  8. docker/
  9. docs/
  10. example/
  11. experimental/
  12. fuzz/
  13. gm/
  14. gn/
  15. include/
  16. infra/
  17. modules/
  18. platform_tools/
  19. resources/
  20. samplecode/
  21. site/
  22. specs/
  23. src/
  24. tests/
  25. third_party/
  26. tools/
  27. .clang-format
  28. .clang-tidy
  29. .gitignore
  30. .gn
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. CONTRIBUTING
  35. CQ_COMMITTERS
  36. DEPS
  37. go.mod
  38. go.sum
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. public.bzl
  43. README
  44. README.chromium
  45. RELEASE_NOTES.txt
  46. whitespace.txt