skia /
skia /
52c763314e75c2590f792df4c685172ab56139f2 Reland "Add setters for providing client info to SkParagraphBuilder"
This reverts commit b1398c9c64a878e4d3e5d8268b0a01bbda060857.
Reason for revert: Fixing the build
Original change's description:
> Revert "Add setters for providing client info to SkParagraphBuilder"
>
> This reverts commit d840c9bc3ef36ee79f991c35488d14013c8b06bb.
>
> Reason for revert: breaking g3 and Android rolls, e.g.
>
> ld.lld: error: undefined symbol: SkUnicode::MakeClientBasedUnicode(SkSpan<char>, std::__1::vector<SkUnicode::BidiRegion, std::__1::allocator<SkUnicode::BidiRegion>>, std::__1::vector<unsigned int, std::__1::allocator<unsigned int>>, std::__1::vector<unsigned int, std::__1::allocator<unsigned int>>, std::__1::vector<SkUnicode::LineBreakBefore, std::__1::allocator<SkUnicode::LineBreakBefore>>)
> >>> referenced by ParagraphBuilderImpl.cpp:161 (external/skia/modules/skparagraph/src/ParagraphBuilderImpl.cpp:161)
> >>> out/soong/.intermediates/external/skia/skia_nanobench/android_arm_armv8-a/obj/external/skia/modules/skparagraph/src/ParagraphBuilderImpl.o:(skia::textlayout::ParagraphBuilderImpl::Build())
> clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Original change's description:
> > Add setters for providing client info to SkParagraphBuilder
> >
> > We need to have UTF8 and UTF16 setters for client info. The reason is that ICU4X produces UTF8 indices, but browser APIs produce UTF16 indices. So SkParagraphBuilder needs to accept both.
> >
> > Change-Id: Ie26e1d728a35c2b2e0d971918c6c079ddbed25ed
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/611560
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Reviewed-by: Julia Lavrova <jlavrova@google.com>
> > Commit-Queue: Julia Lavrova <jlavrova@google.com>
>
> Change-Id: I4f3cb667f992b86f0ed3a121a156fa7716e6a99d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631756
> Auto-Submit: Florin Malita <fmalita@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Julia Lavrova <jlavrova@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
Change-Id: Ie6bfc5cb99d4ca60773e734450c79b06ae49693d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/631837
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
9 files changed
