commit 4af42fcca187398b81b7266d78db748827c2e621
author Brian Osman <brianosman@google.com> Mon Sep 16 12:38:04 2019 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Sep 16 17:13:23 2019 +0000
tree a562ae0e3890102b6d2a06e09155e37c12eb2ba5
parent b9f4881193b2950eee2808da3bdef1f38e78c116

Fix precompiling shaders on GLES / Android

We need to specify attribute locations and (sometimes) frag shader
output locations. Desktop GL worked fine without this, but Flutter
ran into this problem, and a Pixel 2 reproduced the issue.

Note that both APIs (BindFragDataLocation and BindAttribLocation)
don't take effect until the next time the program is linked, so
we have to relink the program after applying those changes.

I was afraid that re-linking would eliminate the perf benefits of
pre-compiling the shaders, but (at least on Pixel 2) that's not
the case. I traced the life of a single program, and the initial
link (during precompile) was 4.4 ms. The re-link took 0.23 ms.

Change-Id: Iadb3b425a8cf9f6a52e015c2e37f875c0fd73d6d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241758
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>