| commit | 463d729cd6db7e06babddbe351c8df4b7789ba5b | [log] [tgz] |
|---|---|---|
| author | Anthony Catel <paraboul@gmail.com> | Wed Jun 03 11:57:19 2020 +0200 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Wed Jun 03 14:19:48 2020 +0000 |
| tree | c2965a1067a4cc87ce2b33ff2a0e64fa1f42cd66 | |
| parent | 5b4a80ad22de9c2d124139284774c556abc10bc2 [diff] |
Fix an "use-after-move" in SkFontMgr_custom_embedded. If a font file has more than one face (e.g. from a .ttc file), the unique_ptr storing the SkMemoryStream instance was reused after being moved, leading to NULL pointer deference in SkTypeface_FreeType::Scanner::openFace() Bug: skia: https://bugs.chromium.org/p/skia/issues/detail?id=10322 Change-Id: I99a53a240a5e7112cd3e67d8c74ff951a9044688 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293519 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>