skia /
skia /
347a9709bbfaf35daac2f1be75cee061b0645086 Reland "[skottie] More snug kTop Shaper alignment"
This reverts commit 80658204f417f90711900b2c761d04f9e835c928.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "[skottie] More snug kTop Shaper alignment"
>
> This reverts commit 7ef3e145160fbe99223249b3cff74fb64df6e7e7.
>
> Reason for revert: TSAN failures (HB?)
>
> Original change's description:
> > [skottie] More snug kTop Shaper alignment
> >
> > The current implementation relies on SkShaper ascent values for top
> > text box alignment, but the results are not as visually accurate as AE
> > (or Lottie).
> >
> > Use the computed tight bounds instead.
> >
> > Change-Id: I4447a834fe3cae398fc887766daa68802e7f50a5
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206684
> > Reviewed-by: Ben Wagner <bungeman@google.com>
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
>
> TBR=bungeman@google.com,fmalita@chromium.org
>
> Change-Id: Icdcca2f6a7b33c8366c1118be2e842ff3978c8bd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206911
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@chromium.org>
TBR=bungeman@google.com,fmalita@chromium.org
Change-Id: I8b72a30b7c2d6d6918f768e59e5d7c987ed5c147
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/207300
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
4 files changed
