| commit | 32b1e5d861b7516104baa315d12a934dea340295 | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Thu Feb 24 12:49:50 2022 +0000 |
| committer | Kevin Lubick <kjlubick@google.com> | Thu Feb 24 12:55:26 2022 +0000 |
| tree | 0f8f804decd47c38977ea28a379f359d728aadc4 | |
| parent | 74b244c06e9ee8043cab81db41952c7008d103c8 [diff] |
Revert "[includes] Remove include link between SkPathRef.h and SkRRect.h" This reverts commit 37b8239bec36c4cba1ad3f89d62babd97e4efd27. Reason for revert: Need to update clients, including Flutter Original change's description: > [includes] Remove include link between SkPathRef.h and SkRRect.h > > According to go/chrome-includes [1], this will save about > 40MB (0.02%) off the Chrome build. http://screen/4GnPjFaYpwCVHVL > > I'm not quite sure why the link is so expensive, but we can > forward declare it and move the implementation from the .h > to the .cpp file easily enough. > > [1] https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html#view=edges&filter=%5Ethird_party%2Fskia%2Finclude%2Fprivate%2FSkPathRef%5C.h%24&sort=includes&reverse=&includer=%5Ethird_party%2Fskia%2Finclude%2Fprivate%2FSkPathRef%5C.h%24&included=&limit=1000 > > Canary-Chromium-CL: 3485346 > Change-Id: Ie3a5e7a735426f883a6c06ddbd3b8bf148bf1709 > Bug: 242216 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512158 > Reviewed-by: Robert Phillips <robertphillips@google.com> Bug: 242216 Change-Id: I226c45326b67dff3eb1dc1f96c11e9ef0a12e22b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512639 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>