Revert "Disallow matrix ctors which overflow a column."
This reverts commit eb68973c2f5ac8f8dd169037cfc32885a024448d.
Reason for revert: ES2 conformance test checks this
Original change's description:
> Disallow matrix ctors which overflow a column.
> The GLSL spec allows matrix constructors containing vectors that would
> split between multiple columns of the matrix. However, in practice, this
> does not actually work well on a lot of GPUs!
> - "cast not allowed", "internal error":
> Tegra 3
> Quadro P400
> GTX 660
> GTX 960
> - Compiles, but generates wrong result:
> Since this isn't a pattern we expect to see in user code, we now report
> it as an error at compile time. mat2(vec4) is treated as an exceptional
> case and still allowed.
> Change-Id: Id6925984a2d1ec948aec4defcc790a197a96cf86
> Bug: skia:12443
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/449518
> Commit-Queue: John Stiles <email@example.com>
> Auto-Submit: John Stiles <firstname.lastname@example.org>
> Reviewed-by: Ethan Nicholas <email@example.com>
Commit-Queue: John Stiles <firstname.lastname@example.org>
Reviewed-by: Leon Scroggins <email@example.com>
26 files changed