commit 0e1161d03f40fc1638481222b06fb74f6a9c734a
author brianosman <brianosman@google.com> Wed Jul 13 09:05:47 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Jul 13 09:05:47 2016 -0700
tree b7900823a6d4290c97a93f1c145df52027ede0fa
parent 6e998e6137e6b25f047b5c5943f2b02485165e3e

Never allow dither for non-legacy (sRGB or F16) targets.

With sRGB, the noise from dithering is (obviously) non-linear, and
highly objectionable for very dark values. With F16, it's completely
unnecessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113793002

Review-Url: https://codereview.chromium.org/2113793002

src/gpu/SkGr.cpp

diff --git a/src/gpu/SkGr.cpp b/src/gpu/SkGr.cpp
index bb0ef91..2694718 100644
--- a/src/gpu/SkGr.cpp
+++ b/src/gpu/SkGr.cpp
@@ -655,7 +655,7 @@
     }
 
 #ifndef SK_IGNORE_GPU_DITHER
-    if (skPaint.isDither() && grPaint->numColorFragmentProcessors() > 0) {
+    if (skPaint.isDither() && grPaint->numColorFragmentProcessors() > 0 && !allowSRGBInputs) {
         grPaint->addColorFragmentProcessor(GrDitherEffect::Make());
     }
 #endif