commit 04cd368cb41f0dd7bce119f61d0ff29d57e22d17
author mtklein <mtklein@chromium.org> Tue Jun 03 09:04:33 2014 -0700
committer Commit bot <commit-bot@chromium.org> Tue Jun 03 09:04:34 2014 -0700
tree 5747a914a581c6bf1b54b077195a57613fc8a89b
parent 14052a0b5adfe2282e6ca70be71ab72a59e5e784

Fix memory leak in etc1bitmap GM.

We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.

BUG=skia:2635
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/310793003

gm/etc1bitmap.cpp

diff --git a/gm/etc1bitmap.cpp b/gm/etc1bitmap.cpp
index bb8ca6f..f61b514 100644
--- a/gm/etc1bitmap.cpp
+++ b/gm/etc1bitmap.cpp
@@ -38,7 +38,7 @@
         SkString filename = SkOSPath::SkPathJoin(
                 INHERITED::gResourcePath.c_str(), "mandrill_512.pkm");
 
-        SkData *fileData = SkData::NewFromFileName(filename.c_str());
+        SkAutoTUnref<SkData> fileData(SkData::NewFromFileName(filename.c_str()));
         if (NULL == fileData) {
             SkDebugf("Could not open the file. Did you forget to set the resourcePath?\n");
             return;