commit 3f751f29adf938e41b006b54c6551c880416d6b9
author Florin Malita <fmalita@chromium.org> Thu Sep 24 14:44:48 2020 -0400
committer Florin Malita <fmalita@google.com> Thu Sep 24 19:56:50 2020 +0000
tree 3fd7f5907b01487c5875061b49e5b559c01c5b9e
parent 9278f107951c918a1db56258500371bab0c92d74

[skottie] Reduce CompositionBuilder stack footprint

LayerBuilder has grown to be pretty chunky.  Using inline storage
SkSTArray<64> in stack-allocated CompositionBuilders is excessive
(and unnecessary).

-fstack-usage before:
  AnimationBuilder::attachPrecompLayer() 7536

-fstack-usage after:
  AnimationBuilder::attachPrecompLayer() 368


Change-Id: Ia905d58e02519d9251620f3eeedbbdc434e3392d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319342
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

modules/skottie/src/Composition.h

diff --git a/modules/skottie/src/Composition.h b/modules/skottie/src/Composition.h
index 740997c..a0356fd 100644
--- a/modules/skottie/src/Composition.h
+++ b/modules/skottie/src/Composition.h
@@ -10,10 +10,11 @@
 
 #include "modules/skottie/src/SkottiePriv.h"
 
-#include "include/private/SkTArray.h"
 #include "include/private/SkTHash.h"
 #include "modules/skottie/src/Layer.h"
 
+#include <vector>
+
 namespace skottie {
 namespace internal {
 
@@ -31,16 +32,16 @@
 
     friend class LayerBuilder;
 
-    const SkSize                fSize;
+    const SkSize              fSize;
 
-    SkSTArray<64, LayerBuilder> fLayerBuilders;
-    SkTHashMap<int, size_t>     fLayerIndexMap; // Maps layer "ind" to layer builder index.
+    std::vector<LayerBuilder> fLayerBuilders;
+    SkTHashMap<int, size_t>   fLayerIndexMap; // Maps layer "ind" to layer builder index.
 
-    sk_sp<sksg::Transform>      fCameraTransform;
+    sk_sp<sksg::Transform>    fCameraTransform;
 
-    size_t                      fMotionBlurSamples = 1;
-    float                       fMotionBlurAngle   = 0,
-                                fMotionBlurPhase   = 0;
+    size_t                    fMotionBlurSamples = 1;
+    float                     fMotionBlurAngle   = 0,
+                              fMotionBlurPhase   = 0;
 };
 
 } // namespace internal