commit 3087c1f382f1cd547598dc75f47ccbc8fe1e6e0f
author Mike Reed <reed@google.com> Wed May 23 08:30:04 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed May 23 13:26:41 2018 +0000
tree 492d99dfb7ad635249286f5299cdcd145489242b
parent b4303caa98d23279a3b5204ac0adbc28d4e33682

tweak tolerance again for cubics

Bug: 845489
Bug: skia:7995
Change-Id: I05554377bd5630b7134864b6db282358613f1030
Reviewed-on: https://skia-review.googlesource.com/129721
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>

src/core/SkScan_Path.cpp

diff --git a/src/core/SkScan_Path.cpp b/src/core/SkScan_Path.cpp
index 1854a7e..90a2230 100644
--- a/src/core/SkScan_Path.cpp
+++ b/src/core/SkScan_Path.cpp
@@ -567,7 +567,9 @@
 //
 // This value has been determined trial and error: pick the smallest value (after the 0.5) that
 // fixes any problematic cases (e.g. crbug.com/844457)
-static const double kConservativeRoundBias = 0.5 + 1.0 / SK_FDot6One;
+// NOTE: cubics appear to be the main reason for needing this slop. If we could (perhaps) have a
+// more accurate walker for cubics, we may be able to reduce this fudge factor.
+static const double kConservativeRoundBias = 0.5 + 1.5 / SK_FDot6One;
 
 /**
  *  Round the value down. This is used to round the top and left of a rectangle,

tests/ClipCubicTest.cpp

diff --git a/tests/ClipCubicTest.cpp b/tests/ClipCubicTest.cpp
index 427e753..ca2f623 100644
--- a/tests/ClipCubicTest.cpp
+++ b/tests/ClipCubicTest.cpp
@@ -212,13 +212,23 @@
     canvas->drawPath(path, paint);
 }
 
-DEF_TEST(cubic_scan_error_crbug_844457, reporter) {
+DEF_TEST(cubic_scan_error_crbug_844457_and_845489, reporter) {
     auto surface(SkSurface::MakeRasterN32Premul(100, 100));
+    SkCanvas* canvas = surface->getCanvas();
+    SkPaint p;
 
     SkPath path;
     path.moveTo(-30/64.0, -31/64.0);
     path.cubicTo(-31/64.0, -31/64,-31/64.0, -31/64,-31/64.0, 100);
-    path.lineTo(100,100);
+    path.lineTo(100, 100);
+    canvas->drawPath(path, p);
 
-    surface->getCanvas()->drawPath(path, SkPaint());
+    // May need to define SK_RASTERIZE_EVEN_ROUNDING to trigger the need for this test
+    path.reset();
+    path.moveTo(-30/64.0f,             -31/64.0f + 1/256.0f);
+    path.cubicTo(-31/64.0f + 1/256.0f, -31/64.0f + 1/256.0f,
+                 -31/64.0f + 1/256.0f, -31/64.0f + 1/256.0f,
+                 -31/64.0f + 1/256.0f, 100);
+    path.lineTo(100, 100);
+    canvas->drawPath(path, p);
 }