commit 710aa46f904eeaeada89005257ed57ebf1019488
author Mike Klein <mtklein@google.com> Wed Sep 12 15:03:42 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Sep 12 19:55:44 2018 +0000
tree de54325b96706ecaa58d01c5a5bd9722d978f547
parent 52df767ea52b9fc983511bd4d275271cb2d9e42b

fix broken test

Ooops, bad loop, and actually, bad logic.

The logic that was there was close to right,
but it ignored rounding.  Instead just write out
the expected values.

Change-Id: I8fec64ffeaf632198ee5bab4be598a3843c3fc9b
Reviewed-on: https://skia-review.googlesource.com/154120
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

tests.c

diff --git a/tests.c b/tests.c
index 2c1337a..cd56a5e 100644
--- a/tests.c
+++ b/tests.c
@@ -249,13 +249,17 @@
     expect(dst[3] == 0xfffffefd);
 
     // We've lost precision when transforming to 8-bit, so these won't quite round-trip.
-    // Instead we should see the most signficant (low) byte doubled, as 65535/255 = 257 = 0x0101.
+    // Instead we should see the 8-bit dst value byte doubled, as 65535/255 = 257 = 0x0101.
     uint16_t back[12];
     expect(skcms_Transform(dst , skcms_PixelFormat_RGBA_8888 , skcms_AlphaFormat_Unpremul, NULL,
                            back, skcms_PixelFormat_RGB_161616, skcms_AlphaFormat_Unpremul, NULL,
                            4));
+    uint16_t expected[] = { 0x0000, 0x0101, 0x0202,
+                            0x0303, 0xfcfc, 0xfdfd,
+                            0xfefe, 0xfefe, 0xfcfc,
+                            0xfdfd, 0xfefe, 0xffff };
     for (int i = 0; i < 12; i++) {
-        expect(back[0] == (src[0] & 0xff) * 0x0101);
+        expect(back[i] == expected[i]);
     }
 }