perf(tests): Don't pre-pass drawCanvases in player yet (#13104) 9c7a56dfc0 ORE commandBuffers currently wired up in a way that causes severe perf regressions and flickering on Vulkan. Once deferred rendering is finished we can turn pre-passes back on in player. Co-authored-by: Chris Dalton <99840794+csmartdalton@users.noreply.github.com>
diff --git a/.rive_head b/.rive_head index e32dc7a..451a471 100644 --- a/.rive_head +++ b/.rive_head
@@ -1 +1 @@ -c7ec04d45d085a3133b31c51413aa2819751a474 +9c7a56dfc0035b963f609c6f09c5be820ca09b85
diff --git a/tests/player/player.cpp b/tests/player/player.cpp index fd0c14e..9c5b8e6 100644 --- a/tests/player/player.cpp +++ b/tests/player/player.cpp
@@ -272,12 +272,7 @@ advanceDeltaTime = 1.0f / 120; } - // ORE auto-reopens its CB if a scripted shader re-enters during PLS - // draw, so we only mark the primary frame here. - TestingWindow::Get()->beginOreFrame(); m_scene->advanceAndApply(paused ? 0 : advanceDeltaTime); - m_artboard->drawCanvases(); - TestingWindow::Get()->endOreFrame(); copiesLeft = std::max(copiesLeft, 0); copiesAbove = std::max(copiesAbove, 0); @@ -340,13 +335,16 @@ m_artboard->bounds()); float spacingPx = spacing * 5 + 150; renderer->translate(-spacingPx * copiesLeft, -spacingPx * copiesAbove); - // drawInternal skips drawCanvases (we pre-passed above), matching - // the Flutter widget's prepassCanvases + paint pattern. for (int y = -copiesAbove; y <= copiesBelow; ++y) { renderer->save(); for (int x = -copiesLeft; x <= copiesRight; ++x) { + // drawInternal skips drawCanvases. In the future we can + // pre-pass them, but ORE commandBuffers are currently wired up + // in a way that causes severe perf regressions and flickering + // on Vulkan. Once deferred rendering is finished we can turn + // pre-passes back on. m_artboard->drawInternal(renderer.get()); renderer->translate(spacingPx, 0); }