commit 72096bf6986d0bcc4543537dcfc581451d36ec29
author ocornut <omarcornut@gmail.com> Tue Aug 23 15:38:47 2022 +0200
committer ocornut <omarcornut@gmail.com> Tue Aug 23 15:40:07 2022 +0200
tree b7d8662e5c5ee4cc97cfa2106e2e2eb5c6f16d67
parent 07b9999de9b7c1a1c07cfbd8d972e193fdbdbfdc

Clipper: simplify code and remove cases where true is returned with empty display range as an extra step.

imgui.cpp

diff --git a/imgui.cpp b/imgui.cpp
index bbc35ba..46f0c0c 100644
--- a/imgui.cpp
+++ b/imgui.cpp
@@ -2669,10 +2669,9 @@
     if (data->StepNo == 0 && table != NULL && !table->IsUnfrozenRows)
     {
         clipper->DisplayStart = data->ItemsFrozen;
-        clipper->DisplayEnd = data->ItemsFrozen + 1;
-        if (clipper->DisplayStart >= clipper->ItemsCount)
-            return false;
-        data->ItemsFrozen++;
+        clipper->DisplayEnd = ImMin(data->ItemsFrozen + 1, clipper->ItemsCount);
+        if (clipper->DisplayStart < clipper->DisplayEnd)
+            data->ItemsFrozen++;
         return true;
     }
 
@@ -2687,8 +2686,6 @@
             data->Ranges.push_front(ImGuiListClipperRange::FromIndices(data->ItemsFrozen, data->ItemsFrozen + 1));
             clipper->DisplayStart = ImMax(data->Ranges[0].Min, data->ItemsFrozen);
             clipper->DisplayEnd = ImMin(data->Ranges[0].Max, clipper->ItemsCount);
-            if (clipper->DisplayStart == clipper->DisplayEnd)
-                return false;
             data->StepNo = 1;
             return true;
         }
@@ -2778,9 +2775,10 @@
 bool ImGuiListClipper::Step()
 {
     ImGuiContext& g = *GImGui;
-    ImGuiWindow* window = g.CurrentWindow;
     bool need_items_height = (ItemsHeight <= 0.0f);
     bool ret = ImGuiListClipper_StepInternal(this);
+    if (ret && (DisplayStart == DisplayEnd))
+        ret = false;
     if (g.CurrentTable && g.CurrentTable->IsUnfrozenRows == false)
         IMGUI_DEBUG_LOG_CLIPPER("Clipper: Step(): inside frozen table row.\n");
     if (need_items_height && ItemsHeight > 0.0f)